openinfra
/
refstack
Code Issues Proposed changes

Update patch set 4 

Patch Set 4: (3 inline comments)

Additional comments in Dockerfile

Patch-set: 4
This commit is contained in:
Gerrit User 10526 2014-03-20 18:22:26 +00:00 committed by Gerrit Code Review
parent 8b8de78a6b
commit c4dacc74f7
1 changed files with 51 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
d9264f1128987be30cb0bcfe97f3a7dac0f1324b
View File

@ -17,6 +17,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAWH//DNY\u003d",
"filename": "Dockerfile",
"patchSetId": 4
},
"lineNbr": 15,
"author": {
"id": 10526
},
"writtenOn": "2014-03-20T18:22:26Z",
"side": 1,
"message": "The earlier design is to build a template of Dockerfile (rather than a static and hard code one) which will be customized at run time. This would avoid building many different Dockerfiles (images).",
"revId": "d9264f1128987be30cb0bcfe97f3a7dac0f1324b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAWH//H0Y\u003d",
@ -34,6 +51,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAWH//DUg\u003d",
"filename": "Dockerfile",
"patchSetId": 4
},
"lineNbr": 27,
"author": {
"id": 10526
},
"writtenOn": "2014-03-20T18:22:26Z",
"side": 1,
"message": "This assumes that the Docker server which hosts the docker containers will have refstack code installed. While this is a reasonable assumption for local testing, the earlier design was for Dockerfile to work for both local and remote Docker servers",
"revId": "d9264f1128987be30cb0bcfe97f3a7dac0f1324b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAWH//IBg\u003d",
@ -68,6 +102,23 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAWH//DK4\u003d",
"filename": "Dockerfile",
"patchSetId": 4
},
"lineNbr": 31,
"author": {
"id": 10526
},
"writtenOn": "2014-03-20T18:22:26Z",
"side": 1,
"message": "With this line as the last line of the Dockerfile, the execute_test.py will be executed every time someone logs into the container and the container will appear as in hung state for the user. This is the reason why the \"RUN echo \"done\"\" statement was added to the earlier Dockerfile template.\n\nThe CMD command ensures that whatever execution statement put on this line will be running as long as the container exists. Since execute_test.py is not a long running app (such as a web server), its execution should end at some point and the user should be able to log into the container. In the case of running stand-alone, user needs to log into the container to get the tempest test results (subunit data..)",
"revId": "d9264f1128987be30cb0bcfe97f3a7dac0f1324b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "AAAAWH//IBo\u003d",