Update patch set 1
Patch Set 1: I would prefer that you didn't merge this (1 inline comment) I prefer you move this change to tcpu.py and have it passes JSON string to --conf-json argument. Patch-set: 1 Reviewer: Gerrit User 10003 <10003@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
parent
1856b7ce4c
commit
fe27b5559a
|
@ -0,0 +1,21 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "AAAAWH/9YFg\u003d",
|
||||
"filename": "refstack/tools/execute_test.py",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 101,
|
||||
"author": {
|
||||
"id": 10003
|
||||
},
|
||||
"writtenOn": "2014-04-05T00:22:26Z",
|
||||
"side": 1,
|
||||
"message": "This change doesn’t break the existing code because it is in a distinct IF block.\n\nHowever, it doesn’t need to be here.\n\nThis execute_test.py is intended to be re-used in multiple code paths for different scenarios.\nThe –conf-json argument is designed to take snippets of tempest conf and agnostic about where the values of the conf are coming from.\n\nOne suggestion is to move this block of code to the caller (tcup.py) and have it passes using –conf-json argument.\n\nTake a look at the examples under Non-Refstack section in the execute_test.py main tab here: https://www.lucidchart.com/documents/view/ed40cb3e-18a6-4121-a990-6d87a7310378",
|
||||
"revId": "9f8f5625182cf8e3dbd4c10b865b179ab8b4fe87",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue