Patch Set 3: Code-Review+2
(2 comments)
> Patch Set 2: -Code-Review
>
> > Patch Set 2: Code-Review-1
> >
> > (2 comments)
> >
> > minor nit regarding hacking rules on how we organize imports.
>
> thanks for noticing, good catch!
> Hmm, isn't there a tox/pep/flake config which would make the tox job fail next time when the import are in the wrong order?
Thanks for revising this. I think the import order check can be added with flake8-import-order, and setting "import-order-style = pep8" in the flake8 section within tox.ini
However, we might find more issues than just the mock library, so we can separate concerns with this change and address that in a separate change.
Patch-set: 3
Reviewer: Gerrit User 16643 <16643@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2
c428f6f8a8