125 lines
3.9 KiB
Plaintext
125 lines
3.9 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAWH/99CI\u003d",
|
|
"filename": "refstack/gearman.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 46,
|
|
"author": {
|
|
"id": 10435
|
|
},
|
|
"writtenOn": "2014-04-01T00:34:25Z",
|
|
"side": 1,
|
|
"message": "We discussed offline the question of how this behaves if we don\u0027t have a defined \"server\" (due to misconfiguration or something). Just putting a note about it, no action required.",
|
|
"revId": "1614a1e63be1f36b37e6fa51b28c42509dd16655",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAWH/99CY\u003d",
|
|
"filename": "refstack/gearman.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 60,
|
|
"author": {
|
|
"id": 10435
|
|
},
|
|
"writtenOn": "2014-04-01T00:34:25Z",
|
|
"side": 1,
|
|
"message": "What do these \"#return build\" comments mean?",
|
|
"revId": "1614a1e63be1f36b37e6fa51b28c42509dd16655",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAWH/9znA\u003d",
|
|
"filename": "refstack/gearman.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 60,
|
|
"author": {
|
|
"id": 6287
|
|
},
|
|
"writtenOn": "2014-04-02T18:11:29Z",
|
|
"side": 1,
|
|
"message": "I\u0027m porting this code form infra-zuul .. which is the glue behind the openstack build engine.. So this is left.. I\u0027ll remove it",
|
|
"parentUuid": "AAAAWH/99CY\u003d",
|
|
"revId": "1614a1e63be1f36b37e6fa51b28c42509dd16655",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAWH/99Bg\u003d",
|
|
"filename": "refstack/gearman.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 64,
|
|
"author": {
|
|
"id": 10435
|
|
},
|
|
"writtenOn": "2014-04-01T00:34:25Z",
|
|
"side": 1,
|
|
"message": "Ideally we should trap only the exceptions that submitJob can be expected to throw, rather than just the generic \"Exception\". Also using \"except FooException, e:\" allows \u0027e\u0027 to be included in the log message (since we\u0027re not letting it bubble up).",
|
|
"revId": "1614a1e63be1f36b37e6fa51b28c42509dd16655",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAWH/99BQ\u003d",
|
|
"filename": "refstack/gearman.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 77,
|
|
"author": {
|
|
"id": 10435
|
|
},
|
|
"writtenOn": "2014-04-01T00:34:25Z",
|
|
"side": 1,
|
|
"message": "result is unused.",
|
|
"revId": "1614a1e63be1f36b37e6fa51b28c42509dd16655",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAWH/9zmo\u003d",
|
|
"filename": "refstack/gearman.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 77,
|
|
"author": {
|
|
"id": 6287
|
|
},
|
|
"writtenOn": "2014-04-02T18:11:29Z",
|
|
"side": 1,
|
|
"message": "this is a stub for the real magic that I have not added yet .. I\u0027ll get better about adding todo\u0027s in code",
|
|
"parentUuid": "AAAAWH/99BQ\u003d",
|
|
"revId": "1614a1e63be1f36b37e6fa51b28c42509dd16655",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "AAAAWH/99A4\u003d",
|
|
"filename": "refstack/gearman.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 83,
|
|
"author": {
|
|
"id": 10435
|
|
},
|
|
"writtenOn": "2014-04-01T00:34:25Z",
|
|
"side": 1,
|
|
"message": "name\u003dNone\n\nand test for it being populated",
|
|
"revId": "1614a1e63be1f36b37e6fa51b28c42509dd16655",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |