Update patch set 12

Patch Set 12: (8 comments) I have some comments. Patch-set: 12 Reviewer: Gerrit User 6482 <6482@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Verified=0
2014-08-26 20:55:56 +00:00 · 2014-08-26 20:55:56 +00:00 · a6c53917d3
parent bbe346e101
commit a6c53917d3
1 changed files with 140 additions and 0 deletions
--- a/140
+++ b/140
@ -0,0 +1,140 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "1abeadc6_1c4a4783",
+        "filename": "v3/src/markdown/identity-api-v3-os-ep-filter-ext.md",
+        "patchSetId": 12
+      },
+      "lineNbr": 11,
+      "author": {
+        "id": 6482
+      },
+      "writtenOn": "2014-08-26T20:55:56Z",
+      "side": 1,
+      "message": "this should have a section like....\n\nWhat\u0027s New in Version 1.1\n------------------------------------",
+      "revId": "7f7067d68eda5d4b2d5277929900f5d8349e00e1",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1abeadc6_1c31670b",
+        "filename": "v3/src/markdown/identity-api-v3-os-ep-filter-ext.md",
+        "patchSetId": 12
+      },
+      "lineNbr": 18,
+      "author": {
+        "id": 6482
+      },
+      "writtenOn": "2014-08-26T20:55:56Z",
+      "side": 1,
+      "message": "s/token/to ?",
+      "revId": "7f7067d68eda5d4b2d5277929900f5d8349e00e1",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1abeadc6_5c12ff62",
+        "filename": "v3/src/markdown/identity-api-v3-os-ep-filter-ext.md",
+        "patchSetId": 12
+      },
+      "lineNbr": 145,
+      "author": {
+        "id": 6482
+      },
+      "writtenOn": "2014-08-26T20:55:56Z",
+      "side": 1,
+      "message": "Should have a *New in version 1.1* section",
+      "revId": "7f7067d68eda5d4b2d5277929900f5d8349e00e1",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1abeadc6_6720089c",
+        "filename": "v3/src/markdown/identity-api-v3-os-ep-filter-ext.md",
+        "patchSetId": 12
+      },
+      "lineNbr": 147,
+      "author": {
+        "id": 6482
+      },
+      "writtenOn": "2014-08-26T20:55:56Z",
+      "side": 1,
+      "message": "if there is a finite set of acceptable filter keys they should be enumerated.\n\nfilters {\n  age: \"20\"\n}\n\nwon\u0027t work, and the values used change throughout the doc.",
+      "revId": "7f7067d68eda5d4b2d5277929900f5d8349e00e1",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1abeadc6_67572803",
+        "filename": "v3/src/markdown/identity-api-v3-os-ep-filter-ext.md",
+        "patchSetId": 12
+      },
+      "lineNbr": 155,
+      "author": {
+        "id": 6482
+      },
+      "writtenOn": "2014-08-26T20:55:56Z",
+      "side": 1,
+      "message": "use either --param_name-- or a real value.\n\nsince 3/4 here are real values, i suggest using a 6 digit uuid.",
+      "revId": "7f7067d68eda5d4b2d5277929900f5d8349e00e1",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1abeadc6_8771a4aa",
+        "filename": "v3/src/markdown/identity-api-v3-os-ep-filter-ext.md",
+        "patchSetId": 12
+      },
+      "lineNbr": 205,
+      "author": {
+        "id": 6482
+      },
+      "writtenOn": "2014-08-26T20:55:56Z",
+      "side": 1,
+      "message": "this should be 204 No Content",
+      "revId": "7f7067d68eda5d4b2d5277929900f5d8349e00e1",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1abeadc6_87a8c4dc",
+        "filename": "v3/src/markdown/identity-api-v3-os-ep-filter-ext.md",
+        "patchSetId": 12
+      },
+      "lineNbr": 293,
+      "author": {
+        "id": 6482
+      },
+      "writtenOn": "2014-08-26T20:55:56Z",
+      "side": 1,
+      "message": "this should go in the next section, since it\u0027s project related",
+      "revId": "7f7067d68eda5d4b2d5277929900f5d8349e00e1",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1abeadc6_677c8873",
+        "filename": "v3/src/markdown/identity-api-v3-os-ep-filter-ext.md",
+        "patchSetId": 12
+      },
+      "lineNbr": 354,
+      "author": {
+        "id": 6482
+      },
+      "writtenOn": "2014-08-26T20:55:56Z",
+      "side": 1,
+      "message": "204 No Content",
+      "revId": "7f7067d68eda5d4b2d5277929900f5d8349e00e1",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}