opendev/gerrit
Code Issues Proposed changes

Hack out some CLA bits.

Browse Source 
Replace the link to the settings/agreements page in the git push error
message with a hardcoded link to the OpenStack wiki.

Remove the form widgets that permit agreeing to a CLA.

Change-Id: Ibfbb8bec245ae494a49cb905925fd2c4f34686f2
This commit is contained in:
James E. Blair 2012-01-06 10:46:32 -08:00
parent cdcd5193d4
commit e707725ee6
2 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
gerrit-gwtui/src/main/java/com/google/gerrit/client/account/NewAgreementScreen.java
View File

@ -143,7 +143,6 @@ public class NewAgreementScreen extends AccountScreen {
}
});
finalGroup.add(submit);
formBody.add(finalGroup);
new OnEditEnabler(submit, yesIAgreeBox);
final FormPanel form = new FormPanel();

8
gerrit-server/src/main/java/com/google/gerrit/server/git/ReceiveCommits.java
View File

@ -524,11 +524,7 @@ public class ReceiveCommits implements PreReceiveHook, PostReceiveHook {
final StringBuilder msg = new StringBuilder();
msg.append(" A Contributor Agreement must be completed before uploading");
if (canonicalWebUrl != null) {
msg.append(":\n\n ");
msg.append(canonicalWebUrl);
msg.append("#");
msg.append(PageLinks.SETTINGS_AGREEMENTS);
msg.append("\n");
msg.append(":\n\n http://wiki.openstack.org/HowToContribute\n");
} else {
msg.append(".");
}
@ -1671,7 +1667,7 @@ public class ReceiveCommits implements PreReceiveHook, PostReceiveHook {
}
}
// Check for people
// Check for people
if (project.isRequireShortMessage() &&
(COMMIT_SUBJECT_LENGTH < c.getShortMessage().length())) {