openstack/ansible-collections-openstack
Code Issues Proposed changes

Dropped default module options

Browse Source 
Removed default=None, type='str' and required=False from all module's
argument_specs with

sed -i \
    -e 's/default=None, //g' \
    -e 's/default=None,//g' \
    -e 's/default=None//g' \
    -e "s/type='str', //g" \
    -e "s/type='str',//g" \
    -e "s/type='str'//g" \
    -e 's/required=False, //g' \
    -e 's/required=False,//g' \
    -e 's/required=False//g' \
    plugins/modules/*.py plugins/module_utils/*.py

and manually cleaned the results because those options values are the
default in Ansible.

Ref.: https://docs.ansible.com/ansible/latest/dev_guide/developing_program_flow_modules.html#argument-spec

Change-Id: Icbc3bb84269d3b8205fac259300902ebdaf6a3ae
This commit is contained in:
Jakob Meng
2022-07-27 12:39:44 +02:00
parent ceae5c1030
commit 0215e2a5d4
72 changed files with 397 additions and 408 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
plugins/modules/coe_cluster_template.py
View File

@@ -290,21 +290,21 @@ class CoeClusterTemplateModule(OpenStackModule):
dns_nameserver=dict(default='8.8.8.8'),
docker_storage_driver=dict(choices=['devicemapper', 'overlay', 'overlay2']),
docker_volume_size=dict(type='int'),
external_network_id=dict(default=None),
fixed_network=dict(default=None),
fixed_subnet=dict(default=None),
flavor_id=dict(default=None),
external_network_id=dict(),
fixed_network=dict(),
fixed_subnet=dict(),
flavor_id=dict(),
floating_ip_enabled=dict(type='bool', default=True),
keypair_id=dict(default=None),
keypair_id=dict(),
image_id=dict(required=True),
labels=dict(default=None, type='raw'),
http_proxy=dict(default=None),
https_proxy=dict(default=None),
labels=dict(type='raw'),
http_proxy=dict(),
https_proxy=dict(),
master_lb_enabled=dict(type='bool', default=False),
master_flavor_id=dict(default=None),
master_flavor_id=dict(),
name=dict(required=True),
network_driver=dict(choices=['flannel', 'calico', 'docker']),
no_proxy=dict(default=None),
no_proxy=dict(),
public=dict(type='bool', default=False),
registry_enabled=dict(type='bool', default=False),
server_type=dict(default="vm", choices=['vm', 'bm']),