openstack/ansible-collections-openstack
Code Issues Proposed changes

Fix regression in quota module

Browse Source 
I suspect that the change to `update_quota_set` in openstacksdk commit
[9145dce64](https://opendev.org/openstack/openstacksdk/commit/9145dcec64)
has caused a regession in the quota module, making it not work correctly
for volume and compute quotas.

This change updates the calls to `update_quota_set` with the new
signatures.

Closes-Bug: #2068568
Change-Id: I604a8ffb08a76c20397f43c0ed3b23ddb11e53eb
This commit is contained in:
Ben Formosa 2024-08-19 20:32:59 +10:00 committed by Sagi Shnaidman
parent d1b77a3546
commit 4a8214b196
2 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ci/run-collection.yml
View File

@ -36,8 +36,7 @@
- { role: object_container, tags: object_container }
- { role: port, tags: port }
- { role: project, tags: project }
# TODO(sshnaidm): Uncomment when the issue with the this test is fixed
# - { role: quota, tags: quota }
- { role: quota, tags: quota }
- { role: recordset, tags: recordset }
- { role: resource, tags: resource }
- { role: resources, tags: resources }

10
plugins/modules/quota.py
View File

@ -404,7 +404,7 @@ class QuotaModule(OpenStackModule):
def _get_quotas(self, project):
quota = {}
if self.conn.has_service('block-storage'):
quota['volume'] = self.conn.block_storage.get_quota_set(project)
quota['volume'] = self.conn.block_storage.get_quota_set(project.id)
else:
self.warn('Block storage service aka volume service is not'
' supported by your cloud. Ignoring volume quotas.')
@ -477,11 +477,11 @@ class QuotaModule(OpenStackModule):
if changes:
if 'volume' in changes:
self.conn.block_storage.update_quota_set(
quotas['volume'], **changes['volume'])
quotas['volume'] = self.conn.block_storage.update_quota_set(
project.id, **changes['volume'])
if 'compute' in changes:
self.conn.compute.update_quota_set(
quotas['compute'], **changes['compute'])
quotas['compute'] = self.conn.compute.update_quota_set(
project.id, **changes['compute'])
if 'network' in changes:
quotas['network'] = self.conn.network.update_quota(
project.id, **changes['network'])