openstack/ansible-collections-openstack
Code Issues Proposed changes

Fix E128 and remove exclusion

Browse Source 
Change-Id: I0517c0ed09d7834df763c745936793739e88ef9d
This commit is contained in:
Monty Taylor
2019-12-09 13:21:34 -05:00
parent 2527faec28
commit 72ba76f156
3 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/modules/os_server_metadata.py
View File

@@ -98,9 +98,11 @@ metadata:
''' '''
from ansible.module_utils.basic import AnsibleModule from ansible.module_utils.basic import AnsibleModule
from ansible_collections.openstack.cloud.plugins.module_utils.openstack import (openstack_full_argument_spec, from ansible_collections.openstack.cloud.plugins.module_utils.openstack import (
openstack_module_kwargs, openstack_full_argument_spec,
openstack_cloud_from_module) openstack_module_kwargs,
openstack_cloud_from_module,
)
def _needs_update(server_metadata=None, metadata=None): def _needs_update(server_metadata=None, metadata=None):

8
plugins/modules/os_volume_snapshot.py
View File

@@ -91,9 +91,11 @@ snapshot:
''' '''
from ansible.module_utils.basic import AnsibleModule from ansible.module_utils.basic import AnsibleModule
from ansible_collections.openstack.cloud.plugins.module_utils.openstack import (openstack_full_argument_spec, from ansible_collections.openstack.cloud.plugins.module_utils.openstack import (
openstack_module_kwargs, openstack_full_argument_spec,
openstack_cloud_from_module) openstack_module_kwargs,
openstack_cloud_from_module,
)
def _present_volume_snapshot(module, cloud): def _present_volume_snapshot(module, cloud):

4
tox.ini
View File

@@ -49,9 +49,9 @@ commands = {posargs}
# Also, both openstacksdk and Donald Knuth disagree with the rule. Line # Also, both openstacksdk and Donald Knuth disagree with the rule. Line
# breaks should occur before the binary operator for readability. # breaks should occur before the binary operator for readability.
# H4 are rules for docstrings. Maybe we should clean them? # H4 are rules for docstrings. Maybe we should clean them?
# E501,E402,H301,H236,F401,E128 are ignored so we can import the existing # E501,E402,H301,H236,F401 are ignored so we can import the existing
# modules unchanged and then clean them in subsequent patches. # modules unchanged and then clean them in subsequent patches.
ignore = W503,H4,E501,E402,H301,H236,F401,E128,W504 ignore = W503,H4,E501,E402,H301,H236,F401,W504
show-source = True show-source = True
exclude=.venv,.git,.tox,dist,doc,*lib/python*,*egg,build,ansible_collections exclude=.venv,.git,.tox,dist,doc,*lib/python*,*egg,build,ansible_collections