691d6b13d0
Patch Set 6:
(1 comment)
Patch-set: 6
Attention: {"person_ident":"Gerrit User 32666 \u003c32666@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_28619\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28619 \u003c28619@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28619\u003e replied on the change"}
39 lines
1.6 KiB
Plaintext
39 lines
1.6 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f831acb8_6fae9a02",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 32666
|
|
},
|
|
"writtenOn": "2023-05-01T10:38:43Z",
|
|
"side": 1,
|
|
"message": "I don\u0027t know if it makes any difference but just to be aware of it:\n\nif you compare \u0027template\u0027 and \u0027config_template\u0027 plugins there is one difference:\nbuilt-in \u0027template\u0027 plugin preserves `\"` while config_template changes `\"` to `\u0027`\n\nhttps://paste.openstack.org/show/bJpd8YbsTjEfFdsBjJz2/",
|
|
"revId": "e528ed0e9e9f3d3fcb2f33ddc5d175faf72094ac",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "47eec863_90d8e490",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 28619
|
|
},
|
|
"writtenOn": "2023-05-01T21:35:18Z",
|
|
"side": 1,
|
|
"message": "yeah, I know that. It\u0027s basically happens because of passing content through YAML Python module. So we load everything in memory and transform to Python object, resolve vars and the write content to destination with yaml.dump. So it while it\u0027s possible to make it use `\"` instead of `\u0027` but then it won\u0027t preserve user\u0027s `\u0027` so I don\u0027t think it matters at the end of the day.",
|
|
"parentUuid": "f831acb8_6fae9a02",
|
|
"revId": "e528ed0e9e9f3d3fcb2f33ddc5d175faf72094ac",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |