openstack
/
ansible-role-collect-logs
Code Issues Proposed changes

Update patch set 9 

Patch Set 9: Code-Review+1

(2 comments)

Patch-set: 9
Reviewer: Gerrit User 8449 <8449@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1
Attention: {"person_ident":"Gerrit User 8367 \u003c8367@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_8449\u003e replied on the change"}
This commit is contained in:
Gerrit User 8449 2022-11-23 10:14:27 +00:00 committed by Gerrit Code Review
parent 30cd91fba2
commit 0102653df8
1 changed files with 46 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

46
b44c7cc7b418b4aa4dad05439e8fdda6823b78cc
View File

@ -33,6 +33,52 @@
"message": "testrepository.subunit created properly https://logserver.rdoproject.org/01/859401/9/openstack-check/tripleo-ci-centos-9-ovb-1ctlr_1comp-featureset001/8851609/logs/testrepository.subunit",
"revId": "b44c7cc7b418b4aa4dad05439e8fdda6823b78cc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "04e2afc8_798366e8",
"filename": "roles/collect_logs/tasks/publish.yml",
"patchSetId": 9
},
"lineNbr": 55,
"author": {
"id": 8449
},
"writtenOn": "2022-11-23T10:14:27Z",
"side": 1,
"message": "what is the benefit of making this less specific?\n\ni.e. .subunit.gz is better than .subunit* unless you expect there is more than one match?",
"range": {
"startLine": 55,
"startChar": 80,
"endLine": 55,
"endChar": 81
},
"revId": "b44c7cc7b418b4aa4dad05439e8fdda6823b78cc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "41904eae_3bf231a5",
"filename": "roles/collect_logs/tasks/publish.yml",
"patchSetId": 9
},
"lineNbr": 56,
"author": {
"id": 8449
},
"writtenOn": "2022-11-23T10:14:27Z",
"side": 1,
"message": "but here you are specifically requiring the .subunit.gz so better to change is as commented above",
"range": {
"startLine": 56,
"startChar": 57,
"endLine": 56,
"endChar": 59
},
"revId": "b44c7cc7b418b4aa4dad05439e8fdda6823b78cc",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}