Commit Graph

91 Commits (master)

Author SHA1 Message Date
Hervé Beraud a091b9cd21 Remove python-dev from bindep
It is no longer supported by jammy and lead us to the following errors with the announce-release job.

No package matching 'python-dev' is available

Change-Id: I262efa933975966d6e078eff4e5778bc00331a92
2022-11-07 10:48:19 +01:00
Chandan Kumar (raukadah) 57da8455f1 Remove CentOS 7 based job is dropping
the c7 based jobs.

It also removes job definitions.

The last run
was from 1 year ago.

We are removing these jobs as a part of ooo_c7_teardown[1].

Added py_modules=[] in to disable auto discovery
and fix linters job.

It also fixes tox molecule issues with no-changed-when
warning errors.


Signed-off-by: Chandan Kumar (raukadah) <>
Change-Id: I94d290321213ae0e097a9ac7d472878940edbafa
2022-05-02 11:14:01 +05:30
Zuul c17c316f23 Merge "setup.cfg: Replace dashes with underscores" 2021-09-14 18:19:45 +00:00
Sagi Shnaidman e745554d51 Use ansible-core 2.11 for tests
Change-Id: Id0f5ed1b2ccd061bedd231c8cb50ecfe7db55d97
2021-09-02 17:12:07 +03:00
Jeremy Stanley a784f1a191 Correct the tox option for skipping sdist generation
The tox option to skip source distribution building is skipsdist,
but this seems to be often misspelled skipdist instead, which gets
silently ignored and so does not take effect. Correct it
everywhere, in hopes that new projects will finally stop copying
this mistake around.

and for details.

Change-Id: Iac474f1d458c3b803eb28a33bd05002db31c4689
2021-06-28 19:37:20 +00:00
Alex Schultz 91f652a932 Fixing ci
* adding task names to satisfy lint
* fixing requirements for test setup

Change-Id: Ic7f019c5f58b456cb36c62283bf72a195d82c299
2021-06-28 13:14:27 -06:00
jiangzhilin 5e435a4264 setup.cfg: Replace dashes with underscores
Setuptools v54.1.0 introduces a warning that the use of dash-separated
options in 'setup.cfg' will not be supported in a future version [1].
Get ahead of the issue by replacing the dashes with underscores. Without
this, we see 'UserWarning' messages like the following on new enough
versions of setuptools:

  UserWarning: Usage of dash-separated 'description-file' will not be
  supported in future versions. Please use the underscore name
  'description_file' instead


Change-Id: I1f6e855b0c9cddaf714bf5750f3edd167ede1527
2021-05-04 07:53:55 +00:00
Alex Schultz 41c93a403d Use ansible_facts
ansible_facts should be used instead of the injected vars

Change-Id: I9e6e0a257d8abf844063b257b3d9026ec8c9ce6c
2021-02-22 12:16:33 -07:00
Alex Schultz 063f15ec2a Fix CI
Update work with newer ansible-lint and address some linting issues.

Change-Id: I69bd204407bd53210492a67bb8f90504a480db11
2021-02-22 12:16:26 -07:00
Alex Schultz dc3a577652 Stop using handlers
With the switch to tripleo_free in stable/train, we can no longer
reliably use handlers.  That being said, handlers don't make sense when
you are forcing them to run with a flush handlers anyway. So this change
takes the code we used in the handler and makes them explicit tasks in
the required locations where we used to do a flush handlers.  This
change should also improve the scope of some tasks to only occur when

Change-Id: I1e31af24a4c1b9356a5971c6c1cb717d39d1e9b2
Closes-Bug: #1909750
2021-01-15 10:32:46 -07:00
Alex Schultz a0a314ade3 Fixup requirements
Require ansible <2.10 and bump hacking

Change-Id: I4b969c4148dd4d75b1e629c389392519c096a8a3
2021-01-11 14:16:43 -07:00
Hervé Beraud 1f05b2d63f Replace deprecated UPPER_CONSTRAINTS_FILE variable
the new environment variable name that replaces it [1].

This allows to use upper-constraints file as more
readable way instead of UPPER_CONSTRAINTS_FILE=<lower-constraints file>.


Change-Id: I56b20e563262e22969ef86df21f5c62fb1355193
2020-11-13 22:43:34 +00:00
Alex Schultz e354ac5fa5 Fix all the ci
1) Bump pyflakes

We need a python 3.9 compatible version.

Related PyCQA/pyflakes #367

2) Fix missing permissions on files

3) Ignore ansible-lint 106 for role name

4) Fix setup-tools install LP#1902986

5) ensure virtualenv is installed

6) fix missing htpasswd

Change-Id: I8302bc6c9250eba78437ccfec35e4de91348333e
2020-11-13 15:23:32 -07:00
Alex Schultz 7eca2dd091 Don't log login
We only will log when the debug option is used.

Change-Id: I6cda4c2f4866cf38d8b561ae4c9b4638d676dd2e
2020-02-20 23:02:09 +00:00
Sorin Sbarnea e904b8213c Migrated to molecule 3.0
Updated configuration files to use newer version of molecule.

Change-Id: I617330a0b8b64028e43fc5d8aa1b7d97d0375ea5
2020-02-20 19:15:34 +00:00
Lukas Bezdicka 7a2a664a84 Don't stop containers before docker package update
Back in Openstack Pike release we hit issue with docker having
changes applied via puppet causing restart of docker service
without --live-restore option. This approach was buggous from the
begining and it's definetly obsolete here. We do only minor updates of
OS during release so we do only patch level updates of docker.

Change-Id: Iff4823d72c4d50838b6997398b23e76cec50ca56
RefBug: #1747851
Closes-Bug: #1851872
2019-11-11 12:37:35 +00:00
Zuul bf2e310791 Merge "Disable docker iptables support" 2019-10-24 19:43:19 +00:00
Sergii Golovatiuk cf8ef9a8d9 Fix race on slow environment
Ansible triggers notifies at the same time. It created a race as "wait
for registry" is dependant on "reload docker-distribution". This patch
moves notifies to dependant service to fix race condition.

Change-Id: I550d5538238ba6100714dd1ca8fcda25292a6773
2019-10-23 14:54:46 +02:00
Sorin Sbarnea 230373ece3 Disable docker iptables support
Change-Id: Ib8a28d84d7363f060170c134ea291e84c3231357
2019-10-03 20:12:48 +01:00
pengyuesheng bdde9e5a00 Update the constraints url
For more detail, see

Change-Id: I0ec62bfa64de9c848db5037dcfa2f202b753f79a
2019-09-24 16:02:50 +08:00
Gabriele Cerami 78da67824a expand login subtasks so it can be used in all rdo jobs
With the upcoming activation of RHEL8 pipeline, we decided with infra it
was better to switch rdo registry to restricted access.
This means that all the job in rdo must login to registry to pull
All the Centos7 jobs must now call this role to login to the registry,
so we are expanding the login part to satisfy the workflow
RHEL8 job with podman will use a internal role instead.

Change-Id: I6e55bdcf493d04bfc88ae22154124a7888563147
2019-09-05 13:08:00 +05:30
Alex Schultz 884a8f6f1b Specify a default for container_registry_logins
When we run this, if we try to evaulate this without the variable being
set it errors. We assume empty if the variable is unset.

Change-Id: Ic6eea050cd627d9d09745bf194c2dd36b015e6ff
Closes-Bug: #1835657
2019-07-12 15:01:20 -06:00
Kevin Carter 1217799b1b
Add molecule testing
This change adds molecule testing using a simple base job and pre|run playbooks.
The test will be executed via a native zuul job and will ensure we're exercising
all of the available code path's as provide by this role.

Two molecule scenarios will be executed whenever any change is made to this role

* default - runs through the typical main code path
* login - tests a secure docker registry ensuring our login capabilities are
          never broken.

Documentation in the readme has been added to show how local testing can be run.

A bindep.txt file has been added to ensure zuul knows how to install our
required base packages.

Closes-Bug: #1835657
Related-Bug: #1833584
Change-Id: I48f74b69c5d29dce4a576fa96e79563a4b484469
Signed-off-by: Kevin Carter <>
2019-07-10 18:42:16 -05:00
Kevin Carter b295cc9aef Covert lookup to query
This change updates our loop so that it will expect a list.

More on the query lookup can be seen here[0]


Change-Id: Id8bfea751a7239fd9be6e9dbbb5a0a700e29b64e
Closes-Bug: #1835657
Related-Bug: #1833584
Signed-off-by: Kevin Carter <>
2019-07-10 14:53:38 -05:00
Zuul 54526ccde7 Merge "Add docker login support" 2019-06-25 22:32:28 +00:00
Alex Schultz 9bf5868d02 Add docker login support
We need to be able to perform a login prior to pulling containers from
registries that require authentication.

Change-Id: Ic3b720ba35db8e3f3f866cd31d9171e91b04a86c
Related-Bug: #1833584
2019-06-20 15:33:31 -06:00
Zuul ed42731b22 Merge "Reduce the number of tripleo jobs" 2019-06-18 20:27:17 +00:00
Rafael Folco 80af0d223e Fix docker network option condition
The option is being ignored. This is useful to adjust settings
like in bug

Change-Id: I9c8f267a92198a06acb3611754bd16278a699df1
Related-Bug: #1654395
2019-06-06 17:46:20 -03:00
Le Hou b54b8acf4d Update to opendev
Change-Id: Iad852417fd90aa04f9c675659c5cec7668d14da8
2019-04-23 10:30:49 +08:00
OpenDev Sysadmins 1aee1a7975 OpenDev Migration Patch
This commit was bulk generated and pushed by the OpenDev sysadmins
as a part of the Git hosting and code review systems migration
detailed in these mailing list posts:

Attempts have been made to correct repository namespaces and
hostnames based on simple pattern matching, but it's possible some
were updated incorrectly or missed entirely. Please reach out to us
via the contact information listed at with any
questions you may have.
2019-04-19 19:30:05 +00:00
Zuul d6a749ace4 Merge "Improve condition checking about docker registry config" 2019-02-18 21:19:29 +00:00
Zuul 30b8d876c6 Merge "Update min tox version to 2.0" 2019-02-18 21:10:47 +00:00
Sorin Sbarnea 0cc18945c6 Improve condition checking about docker registry config
Avoids use of ignore_errors on a task that is only reading the status.

We only use the result code (rc) of the check so the task iself
should not fail regardless if the registry was managed or not.

Improves output of ansible console and confusing false errors.

Change-Id: I0be5f333a7ac6705279820a1a34667b4ec32f760
2019-02-16 10:42:29 +00:00
Zuul be79743b13 Merge "Fix become for tasks and handlers" 2019-01-31 18:42:08 +00:00
Emilien Macchi 70a9413057 docker: add reset_connection
reset ssh connection to pick up docker group after the task that add the
deployment user to docker group.

Change-Id: Ifb9a9ad6c467b8f244665696ed02cdbdc7f9a9de
2019-01-30 20:10:24 +00:00
Alex Schultz df0ca83325 Fix become for tasks and handlers
Some of our tasks and handlers need to be run as root but were
previously missing the become: true option. This change addresses this
to ensure the appropriate tasks and handlers are run as an admin user.

Change-Id: I9cf00809e8725d9220bc993c8fd6602e19ed7aa3
2019-01-29 13:08:16 -07:00
huang.zhiping 30cdb282e5 Update min tox version to 2.0
The commands used by constraints need at least tox 2.0.  Update to
reflect reality, which should help with local running of constraints

Change-Id: I98aa14c59474f019bbbbc45957617e7fc6f31ad1
2019-01-14 20:48:14 +00:00
Alex Schultz 2cba7e32b7 Fix linting issues
Newer versions of ansible lint are stricter. This change fixes up the
issues and ignores rule 405 which requires retries on package items.
We're skipping the retries because yum does that natively.

Change-Id: I9280a736cb1bdeeb1bdcea11ec4ca8f5af9d1e44
2019-01-14 09:51:40 -07:00
Emilien Macchi 61760f2fc1 docker: check if ftype exists
When deploying with --stack-only, the playbooks aren't executed so if a
variable is processed lated, it needs to be checked if it's actually
defined or not otherwise Ansible will fail.

Change-Id: I16a2eed003b8f7fd4c775cdeead3f3b51f8aa467
2018-12-19 17:08:55 +00:00
Alex Schultz 502ee19f48 Reduce the number of tripleo jobs
We only really need an undercloud job for testing at the moment. The
undercloud is the primary consumer of this role anyway.

Change-Id: If2a4be04dd710ea8174bbd0b77bd57c7baf0a6b9
2018-12-19 09:36:36 -07:00
Mike Fedosin 88c26d2cda Allow to skip docker reconfiguration
This commit adds an option `container_registry_skip_reconfiguration`,
that, when enabled, disables the reconfiguration if docker has already
been configured once.

Change-Id: I0bcaeea9cd24ab35a81d8c3d6fc3a384c1e4c3c2
Related-Bug: #1804790
2018-12-10 13:05:05 +01:00
Zuul eb5d61b601 Merge "use include_tasks instead of include" 2018-11-15 07:39:19 +00:00
Alex Schultz 5e1ba52f79 Add xfs ftype check during install
Since we know xfs ftype=0 is incompatible with the container usage,
let's fail hard with a message if the system has an improperly
configured filesystem.

Change-Id: I06f80003d7f3f6443f75f39973d4e68ac24673be
Related-Bug: #1765121
2018-10-25 15:23:30 -06:00
zhulingjie 693c4f3084 use include_tasks instead of include
Change-Id: I5e0dd2f7a230b36ac2ee6fb86ed234c255ee4086
2018-10-11 14:32:11 -04:00
98k f0fab9b956 fix tox python3 overrides
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.

We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.

We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.

Change-Id: Ia848da33224b359c3ac0ad5a57cebc1897369f3e
2018-10-08 03:27:13 +00:00
Zuul ddf8d09aa8 Merge "fix tox python3 overrides" 2018-10-03 16:22:29 +00:00
Andreas Jaeger 119f525395 Remove release-openstack-server
This template needs to stay in project-config to work properly.
also, it's obsolete. project-config is updated already.

Change-Id: I818b10cd6614870fc0673d96d20a9fe66b99ba94
2018-09-28 15:26:18 +02:00
Doug Hellmann a6263fe94e fix tox python3 overrides
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.

We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.

We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.

Change-Id: Ib81683ef8d3677a567d1e62e1ec6adc9a1ed8ea4
Signed-off-by: Doug Hellmann <>
2018-09-26 19:01:41 -04:00
yatin b33f893567 Correctly set registry_pkg_manager
registry_pkg_manager was set to dnf for Centos7 as
well due to wrong string comparison, This patch convert
ansible_distribution_major_version to integer before
comparison and fixes the issue.

Change-Id: I603c1f932c63d07040e6aa24f1a75eab4e389738
Related-Blueprint: dnf-support
2018-09-06 09:12:27 +00:00
Jose Luis Franco Arza d7e0e8f88f Add missing quotes in shell task.
Missing quotes arose as an error in the
minor updates CI job. Adding them.

Change-Id: Ia4aa12411d31ca085480fb126c5c2d60950cfee7
Closes-Bug: #1790786
2018-09-05 09:00:53 +02:00