Update patch set 4
Patch Set 4: (5 comments) Patch-set: 4 Reviewer: Gerrit User 6159 <6159@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Verified=0
This commit is contained in:
parent
b0d5a66306
commit
c7ccf1d324
|
@ -0,0 +1,89 @@
|
||||||
|
{
|
||||||
|
"comments": [
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "df7087c5_719ba565",
|
||||||
|
"filename": "defaults/main.yml",
|
||||||
|
"patchSetId": 4
|
||||||
|
},
|
||||||
|
"lineNbr": 9,
|
||||||
|
"author": {
|
||||||
|
"id": 6159
|
||||||
|
},
|
||||||
|
"writtenOn": "2018-03-21T09:46:57Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "why do you need this variable and the one above?\n\nWe should be able to do everything with what\u0027s in the cinder_config dict. right?",
|
||||||
|
"revId": "82796da846dd4332d83296d212637d9aa879882c",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "df7087c5_f1c33556",
|
||||||
|
"filename": "defaults/main.yml",
|
||||||
|
"patchSetId": 4
|
||||||
|
},
|
||||||
|
"lineNbr": 35,
|
||||||
|
"author": {
|
||||||
|
"id": 6159
|
||||||
|
},
|
||||||
|
"writtenOn": "2018-03-21T09:46:57Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "This dict seems to be duplicated",
|
||||||
|
"revId": "82796da846dd4332d83296d212637d9aa879882c",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "df7087c5_51e6a1ea",
|
||||||
|
"filename": "tasks/provision.yml",
|
||||||
|
"patchSetId": 4
|
||||||
|
},
|
||||||
|
"lineNbr": 1,
|
||||||
|
"author": {
|
||||||
|
"id": 6159
|
||||||
|
},
|
||||||
|
"writtenOn": "2018-03-21T09:46:57Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "should be three - AFAIK",
|
||||||
|
"revId": "82796da846dd4332d83296d212637d9aa879882c",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "df7087c5_11f9097f",
|
||||||
|
"filename": "tasks/provision.yml",
|
||||||
|
"patchSetId": 4
|
||||||
|
},
|
||||||
|
"lineNbr": 6,
|
||||||
|
"author": {
|
||||||
|
"id": 6159
|
||||||
|
},
|
||||||
|
"writtenOn": "2018-03-21T09:46:57Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "Why are you moving to `template` instead of using `config_template`?\n\nI think it\u0027d be better to stick with config_template",
|
||||||
|
"revId": "82796da846dd4332d83296d212637d9aa879882c",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "df7087c5_b1085d91",
|
||||||
|
"filename": "templates/cinder.conf.j2",
|
||||||
|
"patchSetId": 4
|
||||||
|
},
|
||||||
|
"lineNbr": 23,
|
||||||
|
"author": {
|
||||||
|
"id": 6159
|
||||||
|
},
|
||||||
|
"writtenOn": "2018-03-21T09:46:57Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "the connection info is in the `cinder_config` dict. We should probably use that one.",
|
||||||
|
"revId": "82796da846dd4332d83296d212637d9aa879882c",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
Loading…
Reference in New Issue