From 880ed4b185216efdf8a9860896f9bb6f2e4b6ac6 Mon Sep 17 00:00:00 2001
From: "Jesse Pretorius (odyssey4me)" <jesse@odyssey4.me>
Date: Tue, 28 Jul 2020 16:59:26 +0100
Subject: [PATCH] Only create local facts folder when necessary

If we do not plan to set any local facts, we should
not be creating this folder. If we do need to set the
facts, then the tasks will need to be run via sudo to
ensure that they has the appropriate rights to create
the folder/files under /etc.

If this change is not implemented, and the playbook
running this role is not executed as root, then the
task fails because it does not have rights to create
the folder - even when there are no facts to set.

Change-Id: Idcb093775507728a7c68a877a05b8895d4c8c39f
---
 tasks/python_venv_set_facts.yml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tasks/python_venv_set_facts.yml b/tasks/python_venv_set_facts.yml
index df9b761..1a52c15 100644
--- a/tasks/python_venv_set_facts.yml
+++ b/tasks/python_venv_set_facts.yml
@@ -14,11 +14,15 @@
 # limitations under the License.
 
 - name: Ensure local facts folder exists
+  become: true
   file:
     path: /etc/ansible/facts.d
     state: directory
+  when:
+    - venv_facts_when_changed != []
 
 - name: Record the necessary facts
+  become: true
   ini_file:
     dest: "/etc/ansible/facts.d/{{ venv_facts_dest }}.fact"
     section: "{{ item.section }}"