openstack/ansible-role-python_venv_build
Code Issues Proposed changes

Name the venv install block/rescue tasks

Browse Source 
Looking at the output of the tasks, or reviewing them with ARA,
is a bit confusing without the names explaining what they are
doing.

Change-Id: Idb940f011f3b83c222a5acfe6a9430027eb2a657
This commit is contained in:
Jesse Pretorius 2019-04-17 15:25:11 +01:00
parent cce10ac38e
commit 90fe547276
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
tasks/python_venv_install.yml
View File

@ -122,7 +122,8 @@
- name: Install python packages into the venv - name: Install python packages into the venv
block: block:
- pip: - name: Install python packages into the venv
pip:
name: "{{ (venv_default_pip_packages | union(venv_pip_packages)) | sort }}" name: "{{ (venv_default_pip_packages | union(venv_pip_packages)) | sort }}"
state: "{{ venv_pip_package_state }}" state: "{{ venv_pip_package_state }}"
virtualenv: "{{ venv_install_destination_path }}" virtualenv: "{{ venv_install_destination_path }}"
@ -141,14 +142,16 @@
notify: notify:
- venv changed - venv changed
rescue: rescue:
- file: - name: Remove venv requirements/constraints files due to install failure
file:
path: "{{ item }}" path: "{{ item }}"
state: absent state: absent
with_items: with_items:
- "{{ venv_install_destination_path }}/constraints.txt" - "{{ venv_install_destination_path }}/constraints.txt"
- "{{ venv_install_destination_path }}/global-constraints.txt" - "{{ venv_install_destination_path }}/global-constraints.txt"
- "{{ venv_install_destination_path }}/requirements.txt" - "{{ venv_install_destination_path }}/requirements.txt"
- fail: - name: Show venv install failure message
fail:
msg: > msg: >
The python packages have failed to install, please check the log file The python packages have failed to install, please check the log file
located at /var/log/python_venv_build.log for more information. located at /var/log/python_venv_build.log for more information.