openstack
/
ansible-role-redhat-subscription
Code Issues Proposed changes

Bump pyflakes, exclude ansible-lint 106 

We need a python 3.9 compatible version of pyflakes and exclude the role
name ansible-lint rule.

Related PyCQA/pyflakes #367

Change-Id: I44702be1aa668c381da2c54338c72f1d8e33562b
This commit is contained in:
Alex Schultz 2020-11-09 08:36:19 -07:00
parent 6d26afa9c7
commit 405b6b14b3
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
ci-scripts/ansible-lint.sh
View File

@ -1,12 +1,14 @@
#!/bin/bash
# ANSIBLE0006: Using command rather than module
# 303: Using command rather than module
# we have a few use cases where we need to use curl and rsync
# ANSIBLE0016: Tasks that run when changed should likely be handlers
# 503: Tasks that run when changed should likely be handlers
# this requires refactoring roles, skipping for now
# ANSIBLE0012: Commands should not change things if nothing needs doing
# 301: Commands should not change things if nothing needs doing
# this requires refactoring roles, skipping for now
SKIPLIST="ANSIBLE0006,ANSIBLE0016,ANSIBLE0012"
# 106: Role name {} does not match ^[a-z][a-z0-9_]+$ pattern
# this isn't in a collection and we'd need to maintain backwards compat
SKIPLIST="303,503,301,106"
# lint the playbooks separately to avoid linting the roles multiple times
for DIR in tasks playbooks; do

1
test-requirements.txt
View File

@ -1,2 +1,3 @@
hacking!=0.13.0,<0.14,>=0.12.0 # Apache-2.0
bashate>=0.5.1 # Apache-2.0
pyflakes>=2.2.0