Auto-fix yaml rules

In order to reduce divergance with ansible-lint rules, we apply
auto-fixing of violations.

In current patch we replace all kind of truthy variables with
`true` or `false` values to align with recommendations along with
alignment of used quotes.

Change-Id: I9ddc816b49957aba9389c9712afd7d1bb02bd927
This commit is contained in:
Dmitriy Rabotyagov
2025-02-13 09:11:53 +01:00
parent 52490d39d1
commit c2048a7148
7 changed files with 23 additions and 22 deletions

1
.gitignore vendored
View File

@@ -45,6 +45,7 @@ logs/*
# OS generated files # # OS generated files #
###################### ######################
._* ._*
.ansible
.tox .tox
*.egg-info *.egg-info
.eggs .eggs

View File

@@ -1,8 +1,8 @@
--- ---
collections: collections:
- name: https://opendev.org/openstack/ansible-config_template - name: https://opendev.org/openstack/ansible-config_template
version: master version: master
type: git type: git
- name: https://github.com/ansible-collections/ansible.utils - name: https://github.com/ansible-collections/ansible.utils
version: main version: main
type: git type: git

View File

@@ -25,7 +25,7 @@
- "{{ ansible_facts['os_family'] | lower }}.yml" - "{{ ansible_facts['os_family'] | lower }}.yml"
paths: paths:
- "{{ role_path }}/vars" - "{{ role_path }}/vars"
skip: true # skip if no files are found skip: true # skip if no files are found
tags: tags:
- always - always
@@ -39,7 +39,7 @@
copy: copy:
src: "{{ item.keyfile }}" src: "{{ item.keyfile }}"
dest: "{{ item.key }}" dest: "{{ item.key }}"
mode: '0644' mode: "0644"
with_items: "{{ systemd_networkd_package_repos_keys | selectattr('keyfile', 'defined') | list }}" with_items: "{{ systemd_networkd_package_repos_keys | selectattr('keyfile', 'defined') | list }}"
when: when:
- ansible_facts['os_family'] | lower == 'redhat' - ansible_facts['os_family'] | lower == 'redhat'
@@ -72,12 +72,12 @@
yum_repository: yum_repository:
name: epel-networkd name: epel-networkd
baseurl: "{{ systemd_networkd_epel_mirror ~ '/' ~ ansible_facts['distribution_major_version'] ~ '/Everything/' ~ ansible_facts['architecture'] }}" baseurl: "{{ systemd_networkd_epel_mirror ~ '/' ~ ansible_facts['distribution_major_version'] ~ '/Everything/' ~ ansible_facts['architecture'] }}"
description: 'Extra Packages for Enterprise Linux $releasever - $basearch' description: "Extra Packages for Enterprise Linux $releasever - $basearch"
gpgkey: "file://{{ systemd_networkd_package_repos_keys[0].key }}" gpgkey: "file://{{ systemd_networkd_package_repos_keys[0].key }}"
gpgcheck: yes gpgcheck: true
enabled: yes enabled: true
state: present state: present
includepkgs: 'systemd-networkd' includepkgs: "systemd-networkd"
when: when:
- ansible_facts['os_family'] | lower == 'redhat' - ansible_facts['os_family'] | lower == 'redhat'
register: install_epel_repo register: install_epel_repo
@@ -255,9 +255,9 @@
sysctl: sysctl:
name: "net.ipv4.conf.{{ item.1.interface }}.forwarding" name: "net.ipv4.conf.{{ item.1.interface }}.forwarding"
value: 1 value: 1
sysctl_set: yes sysctl_set: true
state: present state: present
reload: yes reload: true
with_indexed_items: "{{ _systemd_networks_named }}" with_indexed_items: "{{ _systemd_networks_named }}"
when: when:
- (ansible_facts['os_family'] | lower) == 'redhat' - (ansible_facts['os_family'] | lower) == 'redhat'

View File

@@ -14,9 +14,9 @@
# limitations under the License. # limitations under the License.
_systemd_networkd_distro_packages: _systemd_networkd_distro_packages:
- dbus # Needed for networkctl - dbus # Needed for networkctl
- "{{ systemd_resolved_available | ternary('systemd-resolved', '') }}" - "{{ systemd_resolved_available | ternary('systemd-resolved', '') }}"
- udev # Needed for networkd to bring interfaces up - udev # Needed for networkd to bring interfaces up
_systemd_resolved_available: false _systemd_resolved_available: false

View File

@@ -14,8 +14,8 @@
# limitations under the License. # limitations under the License.
_systemd_networkd_distro_packages: _systemd_networkd_distro_packages:
- dbus # Needed for networkctl - dbus # Needed for networkctl
- udev # Needed for networkd to bring interfaces up - udev # Needed for networkd to bring interfaces up
_systemd_resolved_available: true _systemd_resolved_available: true

View File

@@ -14,10 +14,10 @@
# limitations under the License. # limitations under the License.
_systemd_networkd_distro_packages: _systemd_networkd_distro_packages:
- dbus # Needed for networkctl - dbus # Needed for networkctl
- systemd-networkd - systemd-networkd
- "{{ systemd_resolved_available | ternary('systemd-resolved', '') }}" - "{{ systemd_resolved_available | ternary('systemd-resolved', '') }}"
- systemd-udev # Needed for networkd to bring interfaces up - systemd-udev # Needed for networkd to bring interfaces up
_systemd_resolved_available: false _systemd_resolved_available: false

View File

@@ -14,9 +14,9 @@
# limitations under the License. # limitations under the License.
_systemd_networkd_distro_packages: _systemd_networkd_distro_packages:
- dbus # Needed for networkctl - dbus # Needed for networkctl
- "{{ systemd_resolved_available | ternary('systemd-resolved', '') }}" - "{{ systemd_resolved_available | ternary('systemd-resolved', '') }}"
- udev # Needed for networkd to bring interfaces up - udev # Needed for networkd to bring interfaces up
_systemd_resolved_available: true _systemd_resolved_available: true