openstack
/
aodh
Code Issues Proposed changes
OpenStack Telemetry (Ceilometer) Alarming
4,804 Commits 9 Branches 84 Tags 20 MiB
Python 98%
Shell 1.8%
Mako 0.2%
Go to file
Zane Bitter 149d3ad219 Don't include trust IDs in Alarm action output 
It was originally envisaged that we would allow users to specify trust
IDs in trust+*:// alarm action URLs, and only create trusts internally
when none was specified. This made storage of trust IDs in the username
field of the URL part of the API interface, and it made sense that the
user would have access to the IDs both for trusts they had created
themselves and those created internally.

However, this proved to be a security hole that was closed by
cb90d3ad47, and now we forbid users from
passing in a trust ID. Any trust IDs that appear in the URL were created
internally.

This causes issues when updating alarms because aodhclient uses a
read-modify-write pattern to do so. The action URLs output from a GET
may contain trust IDs, while the input to a PUT is forbidden from
containing them. This means the data is not round-trippable, so updates
even to unrelated fields fail.

Since storage of the trust ID in action URLs is purely an internal
implementation detail at this point, scrub it out of data returned by
the REST API. This means the output of e.g. a GET will match the
original input data, as the user probably expects, and can be fed back
into a PUT successfully.

Change-Id: I230c0d80a9440c7d002b9a623048ef715a9df743
Closes-Bug: #1737186
Related-Bug: #1649333
(cherry picked from commit 92182de328)
 		2018-04-24 16:17:41 +00:00
aodh Don't include trust IDs in Alarm action output 2018-04-24 16:17:41 +00:00
devstack Remove use of unsupported TEMPEST_SERVICES variable 2018-01-25 02:38:08 +00:00
doc Merge "fix partitioning documentation" 2018-01-30 19:17:26 +00:00
playbooks/legacy tempest: use new plugin + tripleo to experimental 2018-01-16 11:00:23 +01:00
rally-jobs Update and optimize documentation links 2017-07-18 16:03:22 +08:00
releasenotes Imported Translations from Zanata 2018-02-02 06:29:11 +00:00
tools fix gate 2017-09-11 17:21:06 +00:00
.coveragerc Clean config in source code 2016-02-05 08:45:38 +00:00
.gitignore Implement policy in code - reno and doc (end) 2017-11-08 11:18:26 +07:00
.gitreview Update .gitreview for stable/queens 2018-02-14 13:40:51 +00:00
.mailmap add mailmap to avoid dup of authors 2014-10-09 10:31:23 +03:00
.testr.conf Correct concurrency of gabbi tests for gabbi 1.22.0 2016-06-16 12:45:33 +01:00
.zuul.yaml Zuul: Remove project name 2018-01-29 13:20:02 +07:00
CONTRIBUTING.rst Update and optimize documentation links 2017-07-18 16:03:22 +08:00
HACKING.rst Update and optimize documentation links 2017-07-18 16:03:22 +08:00
LICENSE include a copy of the ASL 2.0 2013-03-15 14:25:48 +00:00
MAINTAINERS Clean maintainer list 2017-07-12 05:45:15 +00:00
README.rst update README.rst 2017-12-04 16:01:13 +08:00
babel.cfg Ground work for transifex-ify ceilometer. 2012-12-18 10:14:03 +08:00
bindep.txt tests: simplify tox config 2017-04-28 20:08:02 +02:00
requirements.txt Remove ceilometer-api alarm type 2018-01-12 21:03:25 +01:00
run-functional-tests.sh tests: rework functional live tests 2017-07-13 12:57:41 +02:00
run-tests.sh fix gate 2017-09-11 17:21:06 +00:00
setup.cfg Remove ceilometer-api alarm type 2018-01-12 21:03:25 +01:00
setup.py Update the requirements 2015-07-07 11:42:13 +08:00
tox.ini Fix releasenotes builds 2017-11-22 20:35:32 +01:00

README.rst

aodh

Release notes can be read online at:

https://docs.openstack.org/aodh/latest/contributor/releasenotes/index.html

Documentation for the project can be found at:

https://docs.openstack.org/aodh/latest/

The project home is at:

https://launchpad.net/aodh

Bugs and feature requests are tracked on Launchpad at:

https://bugs.launchpad.net/aodh