Capabilities API returns NotImplementedError in case of SQLAlchemy driver. This issue is fixed in this patch by moving the function into the proper class. Another issue is, that get_capabilities function overwrites the DEFAULT_CAPABILITIES dict in base.py every time, when the function is invoked. This behavior was changed to create a CAPABILITIES dict in each DB driver's __init__ function by making a deep copy from DEFAULT_CAPABILITIES and updating the new dict with the AVAILABLE_CAPABILITIES. get_capabilities now returns the newly created CAPABILITIES dict without modifying it. Tests were also added to check that get_capabilities returns the expected values for each DB driver. Fixes-bug: #1292611 Change-Id: I725751b600bf462c19278e5785eb2d8530023083
104 lines
4.1 KiB
Python
104 lines
4.1 KiB
Python
# -*- encoding: utf-8 -*-
|
|
#
|
|
# Copyright © 2012, 2013 Dell Inc.
|
|
#
|
|
# Author: Stas Maksimov <Stanislav_M@dell.com>
|
|
# Author: Shengjie Min <Shengjie_Min@dell.com>
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
"""Tests for ceilometer/storage/impl_hbase.py
|
|
|
|
.. note::
|
|
In order to run the tests against real HBase server set the environment
|
|
variable CEILOMETER_TEST_HBASE_URL to point to that HBase instance before
|
|
running the tests. Make sure the Thrift server is running on that server.
|
|
|
|
"""
|
|
from mock import patch
|
|
|
|
from ceilometer.storage import impl_hbase as hbase
|
|
from ceilometer.tests import db as tests_db
|
|
|
|
|
|
class HBaseEngineTestBase(tests_db.TestBase):
|
|
database_connection = tests_db.HBaseFakeConnectionUrl()
|
|
|
|
|
|
class ConnectionTest(HBaseEngineTestBase):
|
|
|
|
def test_hbase_connection(self):
|
|
self.CONF.database.connection = str(self.database_connection)
|
|
conn = hbase.Connection(self.CONF)
|
|
self.assertIsInstance(conn.conn, hbase.MConnection)
|
|
|
|
class TestConn(object):
|
|
def __init__(self, host, port):
|
|
self.netloc = '%s:%s' % (host, port)
|
|
|
|
def open(self):
|
|
pass
|
|
|
|
def get_connection(conf):
|
|
return TestConn(conf['host'], conf['port'])
|
|
|
|
self.CONF.database.connection = 'hbase://test_hbase:9090'
|
|
with patch.object(hbase.Connection, '_get_connection',
|
|
side_effect=get_connection):
|
|
conn = hbase.Connection(self.CONF)
|
|
self.assertIsInstance(conn.conn, TestConn)
|
|
|
|
|
|
class CapabilitiesTest(HBaseEngineTestBase):
|
|
# Check the returned capabilities list, which is specific to each DB
|
|
# driver
|
|
|
|
def test_capabilities(self):
|
|
expected_capabilities = {
|
|
'meters': {'pagination': False,
|
|
'query': {'simple': True,
|
|
'metadata': True,
|
|
'complex': False}},
|
|
'resources': {'pagination': False,
|
|
'query': {'simple': True,
|
|
'metadata': True,
|
|
'complex': False}},
|
|
'samples': {'pagination': False,
|
|
'groupby': False,
|
|
'query': {'simple': True,
|
|
'metadata': True,
|
|
'complex': False}},
|
|
'statistics': {'pagination': False,
|
|
'groupby': False,
|
|
'query': {'simple': True,
|
|
'metadata': True,
|
|
'complex': False},
|
|
'aggregation': {'standard': True,
|
|
'selectable': {
|
|
'max': False,
|
|
'min': False,
|
|
'sum': False,
|
|
'avg': False,
|
|
'count': False,
|
|
'stddev': False,
|
|
'cardinality': False}}
|
|
},
|
|
'alarms': {'query': {'simple': False,
|
|
'complex': False},
|
|
'history': {'query': {'simple': False,
|
|
'complex': False}}},
|
|
'events': {'query': {'simple': False}}
|
|
}
|
|
|
|
actual_capabilities = self.conn.get_capabilities()
|
|
self.assertEqual(expected_capabilities, actual_capabilities)
|