
Since https://review.openstack.org/#/c/163462/ and https://review.openstack.org/#/c/162649/4 in gnocchi, all kind of aggregations have been moved in the same URI namespace (/v1/aggregation/...) and we can use complex query to make aggregation across multiples metrics. This change sync the ceilometer alarm API and Rules to match these changes. Change-Id: I015af585595e6880b527161fe5c8b34eeb7bfe29
439 lines
21 KiB
Python
439 lines
21 KiB
Python
#
|
|
# Copyright 2015 eNovance
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import datetime
|
|
import unittest
|
|
import uuid
|
|
|
|
import mock
|
|
from oslo_serialization import jsonutils
|
|
from oslo_utils import timeutils
|
|
from oslotest import mockpatch
|
|
import pytz
|
|
import six
|
|
from six import moves
|
|
|
|
from ceilometer.alarm.evaluator import gnocchi
|
|
from ceilometer.alarm.storage import models
|
|
from ceilometer.tests.alarm.evaluator import base
|
|
from ceilometer.tests import constants
|
|
|
|
|
|
class FakeResponse(object):
|
|
def __init__(self, code, data):
|
|
if code == 200:
|
|
self.values = [d[2] for d in data]
|
|
else:
|
|
self.values = []
|
|
self.text = jsonutils.dumps(data)
|
|
self.status_code = code
|
|
|
|
|
|
class TestGnocchiThresholdEvaluate(base.TestEvaluatorBase):
|
|
EVALUATOR = gnocchi.GnocchiThresholdEvaluator
|
|
|
|
def setUp(self):
|
|
ks_client = mock.Mock(auth_token='fake_token')
|
|
ks_client.users.find.return_value = 'gnocchi'
|
|
self.useFixture(mockpatch.Patch(
|
|
'keystoneclient.v2_0.client.Client',
|
|
return_value=ks_client))
|
|
|
|
super(TestGnocchiThresholdEvaluate, self).setUp()
|
|
|
|
self.useFixture(mockpatch.Patch('ceilometerclient.client.get_client',
|
|
return_value=self.api_client))
|
|
self.requests = self.useFixture(mockpatch.Patch(
|
|
'ceilometer.alarm.evaluator.gnocchi.requests')).mock
|
|
|
|
def prepare_alarms(self):
|
|
self.alarms = [
|
|
models.Alarm(name='instance_running_hot',
|
|
description='instance_running_hot',
|
|
type='gnocchi_resources_threshold',
|
|
enabled=True,
|
|
user_id='foobar',
|
|
project_id='snafu',
|
|
alarm_id=str(uuid.uuid4()),
|
|
state='insufficient data',
|
|
state_timestamp=constants.MIN_DATETIME,
|
|
timestamp=constants.MIN_DATETIME,
|
|
insufficient_data_actions=[],
|
|
ok_actions=[],
|
|
alarm_actions=[],
|
|
repeat_actions=False,
|
|
time_constraints=[],
|
|
rule=dict(
|
|
comparison_operator='gt',
|
|
threshold=80.0,
|
|
evaluation_periods=5,
|
|
aggregation_method='mean',
|
|
granularity=60,
|
|
metric='cpu_util',
|
|
resource_type='instance',
|
|
resource_id='my_instance')
|
|
),
|
|
models.Alarm(name='group_running_idle',
|
|
description='group_running_idle',
|
|
type='gnocchi_aggregation_by_metrics_threshold',
|
|
enabled=True,
|
|
user_id='foobar',
|
|
project_id='snafu',
|
|
state='insufficient data',
|
|
state_timestamp=constants.MIN_DATETIME,
|
|
timestamp=constants.MIN_DATETIME,
|
|
insufficient_data_actions=[],
|
|
ok_actions=[],
|
|
alarm_actions=[],
|
|
repeat_actions=False,
|
|
alarm_id=str(uuid.uuid4()),
|
|
time_constraints=[],
|
|
rule=dict(
|
|
comparison_operator='le',
|
|
threshold=10.0,
|
|
evaluation_periods=4,
|
|
aggregation_method='max',
|
|
granularity=300,
|
|
metrics=['0bb1604d-1193-4c0a-b4b8-74b170e35e83',
|
|
'9ddc209f-42f8-41e1-b8f1-8804f59c4053']),
|
|
),
|
|
models.Alarm(name='instance_not_running',
|
|
description='instance_running_hot',
|
|
type='gnocchi_aggregation_by_resources_threshold',
|
|
enabled=True,
|
|
user_id='foobar',
|
|
project_id='snafu',
|
|
alarm_id=str(uuid.uuid4()),
|
|
state='insufficient data',
|
|
state_timestamp=constants.MIN_DATETIME,
|
|
timestamp=constants.MIN_DATETIME,
|
|
insufficient_data_actions=[],
|
|
ok_actions=[],
|
|
alarm_actions=[],
|
|
repeat_actions=False,
|
|
time_constraints=[],
|
|
rule=dict(
|
|
comparison_operator='gt',
|
|
threshold=80.0,
|
|
evaluation_periods=6,
|
|
aggregation_method='mean',
|
|
granularity=50,
|
|
metric='cpu_util',
|
|
resource_type='instance',
|
|
query='{"=": {"server_group": '
|
|
'"my_autoscaling_group"}}')
|
|
),
|
|
|
|
]
|
|
|
|
@staticmethod
|
|
def _get_stats(granularity, values):
|
|
now = timeutils.utcnow_ts()
|
|
return FakeResponse(
|
|
200, [[six.text_type(now - len(values) * granularity),
|
|
granularity, value] for value in values])
|
|
|
|
@staticmethod
|
|
def _reason_data(disposition, count, most_recent):
|
|
return {'type': 'threshold', 'disposition': disposition,
|
|
'count': count, 'most_recent': most_recent}
|
|
|
|
def _set_all_rules(self, field, value):
|
|
for alarm in self.alarms:
|
|
alarm.rule[field] = value
|
|
|
|
def test_retry_transient_api_failure(self):
|
|
means = self._get_stats(60, [self.alarms[0].rule['threshold'] - v
|
|
for v in moves.xrange(5)])
|
|
maxs = self._get_stats(300, [self.alarms[1].rule['threshold'] + v
|
|
for v in moves.xrange(1, 4)])
|
|
avgs2 = self._get_stats(50, [self.alarms[2].rule['threshold'] - v
|
|
for v in moves.xrange(6)])
|
|
self.requests.get.side_effect = [Exception('boom'),
|
|
FakeResponse(500, "error"),
|
|
means,
|
|
maxs]
|
|
self.requests.post.side_effect = [FakeResponse(500, "error"), avgs2]
|
|
self._evaluate_all_alarms()
|
|
self._assert_all_alarms('insufficient data')
|
|
self._evaluate_all_alarms()
|
|
self._assert_all_alarms('ok')
|
|
|
|
def test_simple_insufficient(self):
|
|
self._set_all_alarms('ok')
|
|
self.requests.get.return_value = FakeResponse(200, [])
|
|
self.requests.post.return_value = FakeResponse(200, [])
|
|
self._evaluate_all_alarms()
|
|
self._assert_all_alarms('insufficient data')
|
|
expected = [mock.call(alarm.alarm_id, state='insufficient data')
|
|
for alarm in self.alarms]
|
|
update_calls = self.api_client.alarms.set_state.call_args_list
|
|
self.assertEqual(expected, update_calls)
|
|
expected = [mock.call(
|
|
alarm,
|
|
'ok',
|
|
('%d datapoints are unknown'
|
|
% alarm.rule['evaluation_periods']),
|
|
self._reason_data('unknown',
|
|
alarm.rule['evaluation_periods'],
|
|
None))
|
|
for alarm in self.alarms]
|
|
self.assertEqual(expected, self.notifier.notify.call_args_list)
|
|
|
|
@mock.patch.object(timeutils, 'utcnow')
|
|
def test_simple_alarm_trip(self, utcnow):
|
|
utcnow.return_value = datetime.datetime(2015, 1, 26, 12, 57, 0, 0)
|
|
self._set_all_alarms('ok')
|
|
avgs = self._get_stats(60, [self.alarms[0].rule['threshold'] + v
|
|
for v in moves.xrange(1, 6)])
|
|
maxs = self._get_stats(300, [self.alarms[1].rule['threshold'] - v
|
|
for v in moves.xrange(4)])
|
|
avgs2 = self._get_stats(50, [self.alarms[2].rule['threshold'] + v
|
|
for v in moves.xrange(1, 7)])
|
|
|
|
self.requests.get.side_effect = [avgs, maxs]
|
|
self.requests.post.side_effect = [avgs2]
|
|
self._evaluate_all_alarms()
|
|
|
|
expected_headers = {'X-Auth-Token': 'fake_token',
|
|
'Content-Type': 'application/json'}
|
|
|
|
start_alarm1 = "2015-01-26T12:51:00"
|
|
start_alarm2 = "2015-01-26T12:32:00"
|
|
start_alarm3 = "2015-01-26T12:51:10"
|
|
end = "2015-01-26T12:57:00"
|
|
|
|
self.assertEqual([
|
|
mock.call(url='http://localhost:8041/v1/resource/instance/'
|
|
'my_instance/metric/cpu_util/measures',
|
|
params={'aggregation': 'mean',
|
|
'start': start_alarm1, 'end': end},
|
|
headers=expected_headers),
|
|
mock.call(url='http://localhost:8041/v1/aggregation/metric',
|
|
params={'aggregation': 'max',
|
|
'start': start_alarm2, 'end': end,
|
|
'metric[]': [
|
|
'0bb1604d-1193-4c0a-b4b8-74b170e35e83',
|
|
'9ddc209f-42f8-41e1-b8f1-8804f59c4053']},
|
|
headers=expected_headers)],
|
|
|
|
self.requests.get.mock_calls)
|
|
self.assertEqual([
|
|
mock.call(url='http://localhost:8041/v1/aggregation/resource/'
|
|
'instance/metric/cpu_util',
|
|
params={'aggregation': 'mean',
|
|
'start': start_alarm3, 'end': end},
|
|
data='{"=": {"server_group": "my_autoscaling_group"}}',
|
|
headers=expected_headers),
|
|
],
|
|
self.requests.post.mock_calls)
|
|
|
|
self._assert_all_alarms('alarm')
|
|
expected = [mock.call(alarm.alarm_id, state='alarm')
|
|
for alarm in self.alarms]
|
|
update_calls = self.api_client.alarms.set_state.call_args_list
|
|
self.assertEqual(expected, update_calls)
|
|
reasons = ['Transition to alarm due to 5 samples outside'
|
|
' threshold, most recent: %s' % avgs.values[-1],
|
|
'Transition to alarm due to 4 samples outside'
|
|
' threshold, most recent: %s' % maxs.values[-1],
|
|
'Transition to alarm due to 6 samples outside'
|
|
' threshold, most recent: %s' % avgs2.values[-1],
|
|
]
|
|
reason_datas = [self._reason_data('outside', 5, avgs.values[-1]),
|
|
self._reason_data('outside', 4, maxs.values[-1]),
|
|
self._reason_data('outside', 6, avgs2.values[-1])]
|
|
expected = [mock.call(alarm, 'ok', reason, reason_data)
|
|
for alarm, reason, reason_data
|
|
in zip(self.alarms, reasons, reason_datas)]
|
|
self.assertEqual(expected, self.notifier.notify.call_args_list)
|
|
|
|
def test_simple_alarm_clear(self):
|
|
self._set_all_alarms('alarm')
|
|
avgs = self._get_stats(60, [self.alarms[0].rule['threshold'] - v
|
|
for v in moves.xrange(5)])
|
|
maxs = self._get_stats(300, [self.alarms[1].rule['threshold'] + v
|
|
for v in moves.xrange(1, 5)])
|
|
avgs2 = self._get_stats(50, [self.alarms[2].rule['threshold'] - v
|
|
for v in moves.xrange(6)])
|
|
self.requests.post.side_effect = [avgs2]
|
|
self.requests.get.side_effect = [avgs, maxs]
|
|
self._evaluate_all_alarms()
|
|
self._assert_all_alarms('ok')
|
|
expected = [mock.call(alarm.alarm_id, state='ok')
|
|
for alarm in self.alarms]
|
|
update_calls = self.api_client.alarms.set_state.call_args_list
|
|
self.assertEqual(expected, update_calls)
|
|
reasons = ['Transition to ok due to 5 samples inside'
|
|
' threshold, most recent: %s' % avgs.values[-1],
|
|
'Transition to ok due to 4 samples inside'
|
|
' threshold, most recent: %s' % maxs.values[-1],
|
|
'Transition to ok due to 6 samples inside'
|
|
' threshold, most recent: %s' % avgs2.values[-1]]
|
|
reason_datas = [self._reason_data('inside', 5, avgs.values[-1]),
|
|
self._reason_data('inside', 4, maxs.values[-1]),
|
|
self._reason_data('inside', 6, avgs2.values[-1])]
|
|
expected = [mock.call(alarm, 'alarm', reason, reason_data)
|
|
for alarm, reason, reason_data
|
|
in zip(self.alarms, reasons, reason_datas)]
|
|
self.assertEqual(expected, self.notifier.notify.call_args_list)
|
|
|
|
def test_equivocal_from_known_state(self):
|
|
self._set_all_alarms('ok')
|
|
avgs = self._get_stats(60, [self.alarms[0].rule['threshold'] + v
|
|
for v in moves.xrange(5)])
|
|
maxs = self._get_stats(300, [self.alarms[1].rule['threshold'] - v
|
|
for v in moves.xrange(-1, 3)])
|
|
avgs2 = self._get_stats(50, [self.alarms[2].rule['threshold'] + v
|
|
for v in moves.xrange(6)])
|
|
self.requests.post.side_effect = [avgs2]
|
|
self.requests.get.side_effect = [avgs, maxs]
|
|
self._evaluate_all_alarms()
|
|
self._assert_all_alarms('ok')
|
|
self.assertEqual(
|
|
[],
|
|
self.api_client.alarms.set_state.call_args_list)
|
|
self.assertEqual([], self.notifier.notify.call_args_list)
|
|
|
|
def test_equivocal_from_known_state_and_repeat_actions(self):
|
|
self._set_all_alarms('ok')
|
|
self.alarms[1].repeat_actions = True
|
|
avgs = self._get_stats(60, [self.alarms[0].rule['threshold'] + v
|
|
for v in moves.xrange(5)])
|
|
maxs = self._get_stats(300, [self.alarms[1].rule['threshold'] - v
|
|
for v in moves.xrange(-1, 3)])
|
|
avgs2 = self._get_stats(50, [self.alarms[2].rule['threshold'] + v
|
|
for v in moves.xrange(6)])
|
|
self.requests.post.side_effect = [avgs2]
|
|
self.requests.get.side_effect = [avgs, maxs]
|
|
self._evaluate_all_alarms()
|
|
self._assert_all_alarms('ok')
|
|
self.assertEqual([], self.api_client.alarms.set_state.call_args_list)
|
|
reason = ('Remaining as ok due to 4 samples inside'
|
|
' threshold, most recent: 8.0')
|
|
reason_datas = self._reason_data('inside', 4, 8.0)
|
|
expected = [mock.call(self.alarms[1], 'ok', reason, reason_datas)]
|
|
self.assertEqual(expected, self.notifier.notify.call_args_list)
|
|
|
|
def test_unequivocal_from_known_state_and_repeat_actions(self):
|
|
self._set_all_alarms('alarm')
|
|
self.alarms[1].repeat_actions = True
|
|
avgs = self._get_stats(60, [self.alarms[0].rule['threshold'] + v
|
|
for v in moves.xrange(1, 6)])
|
|
maxs = self._get_stats(300, [self.alarms[1].rule['threshold'] - v
|
|
for v in moves.xrange(4)])
|
|
avgs2 = self._get_stats(50, [self.alarms[2].rule['threshold'] + v
|
|
for v in moves.xrange(6)])
|
|
self.requests.post.side_effect = [avgs2]
|
|
self.requests.get.side_effect = [avgs, maxs]
|
|
self._evaluate_all_alarms()
|
|
self._assert_all_alarms('alarm')
|
|
self.assertEqual([], self.api_client.alarms.set_state.call_args_list)
|
|
reason = ('Remaining as alarm due to 4 samples outside'
|
|
' threshold, most recent: 7.0')
|
|
reason_datas = self._reason_data('outside', 4, 7.0)
|
|
expected = [mock.call(self.alarms[1], 'alarm',
|
|
reason, reason_datas)]
|
|
self.assertEqual(expected, self.notifier.notify.call_args_list)
|
|
|
|
def test_state_change_and_repeat_actions(self):
|
|
self._set_all_alarms('ok')
|
|
self.alarms[0].repeat_actions = True
|
|
self.alarms[1].repeat_actions = True
|
|
avgs = self._get_stats(60, [self.alarms[0].rule['threshold'] + v
|
|
for v in moves.xrange(1, 6)])
|
|
maxs = self._get_stats(300, [self.alarms[1].rule['threshold'] - v
|
|
for v in moves.xrange(4)])
|
|
avgs2 = self._get_stats(50, [self.alarms[2].rule['threshold'] + v
|
|
for v in moves.xrange(1, 7)])
|
|
self.requests.post.side_effect = [avgs2]
|
|
self.requests.get.side_effect = [avgs, maxs]
|
|
self._evaluate_all_alarms()
|
|
self._assert_all_alarms('alarm')
|
|
expected = [mock.call(alarm.alarm_id, state='alarm')
|
|
for alarm in self.alarms]
|
|
update_calls = self.api_client.alarms.set_state.call_args_list
|
|
self.assertEqual(expected, update_calls)
|
|
reasons = ['Transition to alarm due to 5 samples outside'
|
|
' threshold, most recent: %s' % avgs.values[-1],
|
|
'Transition to alarm due to 4 samples outside'
|
|
' threshold, most recent: %s' % maxs.values[-1],
|
|
'Transition to alarm due to 6 samples outside'
|
|
' threshold, most recent: %s' % avgs2.values[-1]]
|
|
reason_datas = [self._reason_data('outside', 5, avgs.values[-1]),
|
|
self._reason_data('outside', 4, maxs.values[-1]),
|
|
self._reason_data('outside', 6, avgs2.values[-1])]
|
|
expected = [mock.call(alarm, 'ok', reason, reason_data)
|
|
for alarm, reason, reason_data
|
|
in zip(self.alarms, reasons, reason_datas)]
|
|
self.assertEqual(expected, self.notifier.notify.call_args_list)
|
|
|
|
def test_equivocal_from_unknown(self):
|
|
self._set_all_alarms('insufficient data')
|
|
avgs = self._get_stats(60, [self.alarms[0].rule['threshold'] + v
|
|
for v in moves.xrange(1, 6)])
|
|
maxs = self._get_stats(300, [self.alarms[1].rule['threshold'] - v
|
|
for v in moves.xrange(4)])
|
|
avgs2 = self._get_stats(50, [self.alarms[2].rule['threshold'] + v
|
|
for v in moves.xrange(1, 7)])
|
|
self.requests.post.side_effect = [avgs2]
|
|
self.requests.get.side_effect = [avgs, maxs]
|
|
self._evaluate_all_alarms()
|
|
self._assert_all_alarms('alarm')
|
|
expected = [mock.call(alarm.alarm_id, state='alarm')
|
|
for alarm in self.alarms]
|
|
update_calls = self.api_client.alarms.set_state.call_args_list
|
|
self.assertEqual(expected, update_calls)
|
|
reasons = ['Transition to alarm due to 5 samples outside'
|
|
' threshold, most recent: %s' % avgs.values[-1],
|
|
'Transition to alarm due to 4 samples outside'
|
|
' threshold, most recent: %s' % maxs.values[-1],
|
|
'Transition to alarm due to 6 samples outside'
|
|
' threshold, most recent: %s' % avgs2.values[-1]]
|
|
reason_datas = [self._reason_data('outside', 5, avgs.values[-1]),
|
|
self._reason_data('outside', 4, maxs.values[-1]),
|
|
self._reason_data('outside', 6, avgs2.values[-1])]
|
|
expected = [mock.call(alarm, 'insufficient data',
|
|
reason, reason_data)
|
|
for alarm, reason, reason_data
|
|
in zip(self.alarms, reasons, reason_datas)]
|
|
self.assertEqual(expected, self.notifier.notify.call_args_list)
|
|
|
|
@unittest.skipIf(six.PY3,
|
|
"the ceilometer base class is not python 3 ready")
|
|
@mock.patch.object(timeutils, 'utcnow')
|
|
def test_no_state_change_outside_time_constraint(self, mock_utcnow):
|
|
self._set_all_alarms('ok')
|
|
self.alarms[0].time_constraints = [
|
|
{'name': 'test',
|
|
'description': 'test',
|
|
'start': '0 11 * * *', # daily at 11:00
|
|
'duration': 10800, # 3 hours
|
|
'timezone': 'Europe/Ljubljana'}
|
|
]
|
|
self.alarms[1].time_constraints = self.alarms[0].time_constraints
|
|
self.alarms[2].time_constraints = self.alarms[0].time_constraints
|
|
dt = datetime.datetime(2014, 1, 1, 15, 0, 0,
|
|
tzinfo=pytz.timezone('Europe/Ljubljana'))
|
|
mock_utcnow.return_value = dt.astimezone(pytz.UTC)
|
|
self.requests.get.return_value = []
|
|
self._evaluate_all_alarms()
|
|
self._assert_all_alarms('ok')
|
|
update_calls = self.api_client.alarms.set_state.call_args_list
|
|
self.assertEqual([], update_calls,
|
|
"Alarm should not change state if the current "
|
|
" time is outside its time constraint.")
|
|
self.assertEqual([], self.notifier.notify.call_args_list)
|