openstack/arch-wg
Code Issues Proposed changes

Update patch set 1

Browse Source 
Patch Set 1:

(4 comments)

Good sensible start, some clarity suggestions within.

Patch-set: 1
Label: Verified=0
This commit is contained in:
Gerrit User 11564 2016-12-08 11:34:22 +00:00 committed by Gerrit Code Review
parent c0bbe1c0da
commit 8ad3eb53b2
1 changed files with 72 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
bf3ff38c4f363fd907d8897ad8b0067c16851120 Normal file
View File

@ -0,0 +1,72 @@
{
"comments": [
{
"key": {
"uuid": "3a71b18c_a462bcab",
"filename": "proposals/base-services.rst",
"patchSetId": 1
},
"lineNbr": 54,
"author": {
"id": 11564
},
"writtenOn": "2016-12-08T11:34:22Z",
"side": 1,
"message": "This could be read and inter project communication being via message queues (which is sometimes true) and not include components within projects (e.g, api\u003c-\u003econductor\u003c-\u003ecompute in nova).\n\nAlso it is a bit prescriptive; there is also communication that happens via other methods, including HTTP.\n\nSo it might make more sense to be a bit more explicit:\n\nSome inter-process and inter-service communication in OpenStack components is accomplished using message queues.",
"revId": "bf3ff38c4f363fd907d8897ad8b0067c16851120",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a71b18c_c41fb859",
"filename": "proposals/base-services.rst",
"patchSetId": 1
},
"lineNbr": 55,
"author": {
"id": 11564
},
"writtenOn": "2016-12-08T11:34:22Z",
"side": 1,
"message": "through?",
"revId": "bf3ff38c4f363fd907d8897ad8b0067c16851120",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a71b18c_0420d048",
"filename": "proposals/base-services.rst",
"patchSetId": 1
},
"lineNbr": 61,
"author": {
"id": 11564
},
"writtenOn": "2016-12-08T11:34:22Z",
"side": 1,
"message": "This second sentence is overly complex. maybe:\n\nDeployments can assume that Keystone will be present to perform that role.",
"revId": "bf3ff38c4f363fd907d8897ad8b0067c16851120",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a71b18c_c4aa5885",
"filename": "proposals/base-services.rst",
"patchSetId": 1
},
"lineNbr": 83,
"author": {
"id": 11564
},
"writtenOn": "2016-12-08T11:34:22Z",
"side": 1,
"message": "s/allows to give/gives/",
"revId": "bf3ff38c4f363fd907d8897ad8b0067c16851120",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}