enable all hacking checks

This change will now cause gate failures for any CR that is not
hacking clean.

Change-Id: I4e61e5940ef6da61aced1c44e91760f72f1d347e

barbican/crypto/plugin.py

@@ -16,10 +16,10 @@
 import abc
 import os
 
-from cryptography import fernet
 from Crypto.PublicKey import DSA
 from Crypto.PublicKey import RSA
 from Crypto.Util import asn1
+from cryptography import fernet
 
 from oslo.config import cfg
 

tools/hacking.sh

@@ -1,4 +0,0 @@
-#!/bin/bash
-set -o pipefail
-flake8 barbican | tee flake8.log 
-exit $?

tox.ini

@@ -14,12 +14,11 @@ commands =
 commands = coverage html {posargs:--include="*barbican*"}
 
 [testenv:pep8]
-commands = {toxinidir}/tools/hacking.sh {posargs}
+sitepackages = False
+commands = flake8 {posargs}
 
 [flake8]
 # E711 ignored because of sqlalchemy override of == None
-# H ignored because it's not H clean
-ignore = E711,H
-select = H234
+ignore = E711
 exclude = .git,.idea,.tox,bin,dist,debian,rpmbuild,tools,*.egg-info,*openstack/common,contrib,
           functionaltests,*alembic_migrations/versions