openstack/barbican
Code Issues Proposed changes

Remove unnecessary checks from migration commands

Browse Source 
When doing the alembic setup to enable the usage of the commands API,
there were some unnecessary checks in each command to verify that the
alembic configuration isn't a falsey value. Although, there is no
scenario where this could happen, since proper exceptions are thrown.
So this fixes that.

Change-Id: Ibc1b2ebefd13d7569e1ff69de873cfc557804a76
This commit is contained in:
Juan Antonio Osorio Robles 2015-01-28 23:08:16 +02:00
parent 1379202618
commit 6ad6ca2b65
1 changed files with 7 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
barbican/model/migration/commands.py
View File

@ -64,39 +64,33 @@ def init_config(sql_url=None):
def upgrade(to_version='head', sql_url=None):
"""Upgrade to the specified version."""
alembic_cfg = init_config(sql_url)
if alembic_cfg:
alembic_command.upgrade(alembic_cfg, to_version)
alembic_command.upgrade(alembic_cfg, to_version)
def downgrade(to_version, sql_url=None):
"""Downgrade to the specified version."""
alembic_cfg = init_config(sql_url)
if alembic_cfg:
alembic_command.downgrade(alembic_cfg, to_version)
alembic_command.downgrade(alembic_cfg, to_version)
def history(verbose, sql_url=None):
alembic_cfg = init_config(sql_url)
if alembic_cfg:
alembic_command.history(alembic_cfg, verbose=verbose)
alembic_command.history(alembic_cfg, verbose=verbose)
def current(verbose, sql_url=None):
alembic_cfg = init_config(sql_url)
if alembic_cfg:
alembic_command.current(alembic_cfg, verbose=verbose)
alembic_command.current(alembic_cfg, verbose=verbose)
def stamp(to_version='head', sql_url=None):
"""Stamp the specified version, with no migration performed."""
alembic_cfg = init_config(sql_url)
if alembic_cfg:
alembic_command.stamp(alembic_cfg, to_version)
alembic_command.stamp(alembic_cfg, to_version)
def generate(autogenerate=True, message='generate changes', sql_url=None):
"""Generate a version file."""
alembic_cfg = init_config(sql_url)
if alembic_cfg:
alembic_command.revision(alembic_cfg, message=message,
autogenerate=autogenerate)
alembic_command.revision(alembic_cfg, message=message,
autogenerate=autogenerate)