openstack/barbican
Code Issues Proposed changes

Remove hardcoded 'localhost' references

Browse Source 
This patch fixes two tests that fail if the barbican service
under test is not listening on localhost.

Change-Id: I541ee6a44bd86fbd963930dd2423fb9af833eec1
This commit is contained in:
Douglas Mendizábal 2019-01-31 16:41:35 -06:00
parent ebf1567ed2
commit 6dc5259012
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
functionaltests/api/v1/functional/test_secretmeta.py
View File

@ -82,8 +82,9 @@ class SecretMetadataTestCase(base.TestCase):
@testcase.attr('negative') @testcase.attr('negative')
def test_secret_metadata_create_no_secret(self): def test_secret_metadata_create_no_secret(self):
secret_ref = ('http://localhost/key-manager/secrets/%s' % secret_ref = ('{}/secrets/{}/metadata'.format(
uuidutils.generate_uuid(dashed=False)) self.client.get_base_url(),
uuidutils.generate_uuid(dashed=False)))
meta_resp, metadata_ref = self.behaviors.create_or_update_metadata( meta_resp, metadata_ref = self.behaviors.create_or_update_metadata(
secret_ref, self.invalid_metadata) secret_ref, self.invalid_metadata)
@ -111,8 +112,9 @@ class SecretMetadataTestCase(base.TestCase):
@testcase.attr('negative') @testcase.attr('negative')
def test_secret_metadata_get_no_secret(self): def test_secret_metadata_get_no_secret(self):
secret_ref = ('http://localhost/key-manager/secrets/%s' % secret_ref = ('{}/secrets/{}/metadata'.format(
uuidutils.generate_uuid(dashed=False)) self.client.get_base_url(),
uuidutils.generate_uuid(dashed=False)))
get_resp = self.behaviors.get_metadata(secret_ref) get_resp = self.behaviors.get_metadata(secret_ref)
self.assertEqual(404, get_resp.status_code) self.assertEqual(404, get_resp.status_code)