openstack/barbican
Code Issues Proposed changes

Remove ERROR_ON_CLONE references

Browse Source 
It is *never* acceptable to manipulate this variable.  It defeats
devstack gate testing.

Change-Id: Iea79f237a9b1daf3c4352fb0e2b5b78a58203b02
This commit is contained in:
James E. Blair 2015-09-23 13:55:19 -07:00
parent 1cf5b54b96
commit d18255e5e2
2 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
contrib/devstack/lib/barbican
View File

@ -188,8 +188,6 @@ function install_barbican {
if is_fedora; then if is_fedora; then
install_package sqlite-devel openldap-devel install_package sqlite-devel openldap-devel
fi fi
# TODO(ravips): We need this until barbican gets into devstack
ERROR_ON_CLONE=False
git_clone $BARBICAN_REPO $BARBICAN_DIR $BARBICAN_BRANCH git_clone $BARBICAN_REPO $BARBICAN_DIR $BARBICAN_BRANCH
setup_develop $BARBICAN_DIR setup_develop $BARBICAN_DIR
pip_install 'uwsgi' pip_install 'uwsgi'
@ -197,8 +195,6 @@ function install_barbican {
# install_barbicanclient - Collect source and prepare # install_barbicanclient - Collect source and prepare
function install_barbicanclient { function install_barbicanclient {
# TODO(ravips): We need this until barbican gets into devstack
ERROR_ON_CLONE=False
git_clone $BARBICANCLIENT_REPO $BARBICANCLIENT_DIR $BARBICANCLIENT_BRANCH git_clone $BARBICANCLIENT_REPO $BARBICANCLIENT_DIR $BARBICANCLIENT_BRANCH
setup_develop $BARBICANCLIENT_DIR setup_develop $BARBICANCLIENT_DIR
} }

2
devstack/lib/barbican
View File

@ -167,8 +167,6 @@ function install_barbican {
# install_barbicanclient - Collect source and prepare # install_barbicanclient - Collect source and prepare
function install_barbicanclient { function install_barbicanclient {
# TODO(ravips): We need this until barbican gets into devstack
ERROR_ON_CLONE=False
git_clone $BARBICANCLIENT_REPO $BARBICANCLIENT_DIR $BARBICANCLIENT_BRANCH git_clone $BARBICANCLIENT_REPO $BARBICANCLIENT_DIR $BARBICANCLIENT_BRANCH
setup_develop $BARBICANCLIENT_DIR setup_develop $BARBICANCLIENT_DIR
} }