From edc2316712238d5d7f1282819613d99b90e0f071 Mon Sep 17 00:00:00 2001 From: Zhao Lei Date: Wed, 23 Sep 2015 18:45:40 +0800 Subject: [PATCH] Remove quotes from subshell call in bash script Always no quotes for $() statement. We don't need quotes to hold blanks in result: # i=$(echo 1 2 3) # echo $i 1 2 3 # These quotes can make something wrong in some case: # i=$(echo '!') # # i="$(echo '!')" -bash: !: event not found # No real problem for current code, only to use a better code style. Change-Id: I865069a1aa0384d13feed7249cadb2f34b6cf99d Signed-off-by: Zhao Lei --- bin/barbican.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/barbican.sh b/bin/barbican.sh index 9ae9205ea..cf95ac5ba 100755 --- a/bin/barbican.sh +++ b/bin/barbican.sh @@ -14,7 +14,7 @@ then fi LOCAL_CONFIG=$LOCAL_CONFIG_DIR/barbican.conf -DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" +DIR=$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd ) echo 'DIR: '$DIR debug_barbican()