Gate jobs are voting

Make grenade-devstack-barbican voting, all gate jobs should be voting -
or not run in gate at all since they only waste resources and get
ignored. The job is passing, so making it voting is the proper change.

Rename job also to follow naming guidelines for zuul jobs, see
https://docs.openstack.org/infra/manual/drivers.html#naming-with-zuul-v3

Change-Id: Ib5691b03e360631658e7fd80f958f55030a29782

.zuul.yaml

@@ -129,7 +129,7 @@
       cursive: 1
 
 - job:
-    name: grenade-devstack-barbican
+    name: barbican-grenade-devstack
     parent: legacy-dsvm-base
     # Start testing with pike
     branches: ^(?!stable/ocata).*$
@@ -165,8 +165,7 @@
         - barbican-kmip-devstack-functional:
             voting: false
         - barbican-vault-devstack-functional
-        - grenade-devstack-barbican:
-            voting: false
+        - barbican-grenade-devstack
         # TripleO jobs that deploy Barbican.
         # Note we don't use a project-template here, so it's easier
         # to disable voting on one specific job if things go wrong.
@@ -185,5 +184,4 @@
         - barbican-simple-crypto-devstack-functional
         - barbican-dogtag-devstack-functional-fedora-latest
         - barbican-vault-devstack-functional
-        - grenade-devstack-barbican:
-            voting: false
+        - barbican-grenade-devstack