openstack
/
castellan
Code Issues Proposed changes

Update patch set 6 

Patch Set 6:

(4 comments)

I had overlooked MockKeyManager -- I didn't have such a thing implemented for the CertificateManager (soon to be a follow-on CR), in favor of LocalCertificateManager, but that was only because I didn't think to make a Mock version. MockCertificateManager might be a better solution for dev/test purposes.

Patch-set: 6
This commit is contained in:
Gerrit User 10273 2015-02-09 23:58:18 +00:00 committed by Gerrit Code Review
parent e38b163cf6
commit 57e609fd8b
1 changed files with 72 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
df5dffe333e6f7a1b5fe36656448f71454213ca2
View File

@ -68,6 +68,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da86d52c_829c225f",
"filename": "castellan/keymgr/__init__.py",
"patchSetId": 6
},
"lineNbr": 21,
"author": {
"id": 10273
},
"writtenOn": "2015-02-09T23:58:18Z",
"side": 1,
"message": "Good catch.",
"parentUuid": "da86d52c_7a3a8599",
"revId": "df5dffe333e6f7a1b5fe36656448f71454213ca2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da86d52c_3afe4daf",
@ -119,6 +137,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da86d52c_a2d046f8",
"filename": "castellan/keymgr/key_mgr.py",
"patchSetId": 6
},
"lineNbr": 28,
"author": {
"id": 10273
},
"writtenOn": "2015-02-09T23:58:18Z",
"side": 1,
"message": "The \"Encryption service\" is Barbican, or some HSM or something. I somewhat agree that we should just call this what it is for OpenStack -- Keystone URI.",
"parentUuid": "da86d52c_9712b460",
"revId": "df5dffe333e6f7a1b5fe36656448f71454213ca2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da86d52c_da129157",
@ -136,6 +172,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da86d52c_2204567d",
"filename": "castellan/keymgr/key_mgr.py",
"patchSetId": 6
},
"lineNbr": 31,
"author": {
"id": 10273
},
"writtenOn": "2015-02-09T23:58:18Z",
"side": 1,
"message": "As above, this is a reference to the Barbican endpoint.",
"parentUuid": "da86d52c_da129157",
"revId": "df5dffe333e6f7a1b5fe36656448f71454213ca2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da86d52c_774d4099",
@ -152,6 +206,24 @@
"revId": "df5dffe333e6f7a1b5fe36656448f71454213ca2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da86d52c_a2f7668b",
"filename": "castellan/keymgr/key_mgr.py",
"patchSetId": 6
},
"lineNbr": 32,
"author": {
"id": 10273
},
"writtenOn": "2015-02-09T23:58:18Z",
"side": 1,
"message": "I think it is worthwhile to have these configurable (for example, Keystone URI is configurable for pretty much every project I\u0027ve seen).",
"parentUuid": "da86d52c_774d4099",
"revId": "df5dffe333e6f7a1b5fe36656448f71454213ca2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}