diff --git a/ceilometer/cmd/storage.py b/ceilometer/cmd/storage.py index aac50b8141..e21345da52 100644 --- a/ceilometer/cmd/storage.py +++ b/ceilometer/cmd/storage.py @@ -20,14 +20,14 @@ from six import moves import six.moves.urllib.parse as urlparse import sqlalchemy as sa -from ceilometer.i18n import _LE, _LI, _LW +from ceilometer.i18n import _LE, _LI from ceilometer import service from ceilometer import storage LOG = log.getLogger(__name__) -def upgrade(default_skip_gnocchi_resource_types=False): +def upgrade(): cfg.CONF.register_cli_opts([ cfg.BoolOpt('skip-metering-database', help='Skip metering database upgrade.', @@ -37,7 +37,7 @@ def upgrade(default_skip_gnocchi_resource_types=False): default=False), cfg.BoolOpt('skip-gnocchi-resource-types', help='Skip gnocchi resource-types upgrade.', - default=default_skip_gnocchi_resource_types), + default=False), ]) service.prepare_service() @@ -61,12 +61,6 @@ def upgrade(default_skip_gnocchi_resource_types=False): gnocchi_client.upgrade_resource_types(cfg.CONF) -def dbsync(): - LOG.warning(_LW('ceilometer-dbsync is deprecated in favor of ' - 'ceilometer-upgrade')) - upgrade(default_skip_gnocchi_resource_types=True) - - def expirer(): service.prepare_service() diff --git a/ceilometer/tests/functional/test_bin.py b/ceilometer/tests/functional/test_bin.py index 7d9ca89e4f..e1117520e2 100644 --- a/ceilometer/tests/functional/test_bin.py +++ b/ceilometer/tests/functional/test_bin.py @@ -39,8 +39,9 @@ class BinTestCase(base.BaseTestCase): super(BinTestCase, self).tearDown() os.remove(self.tempfile) - def test_dbsync_run(self): - subp = subprocess.Popen(['ceilometer-dbsync', + def test_upgrade_run(self): + subp = subprocess.Popen(['ceilometer-upgrade', + '--skip-gnocchi-resource-types', "--config-file=%s" % self.tempfile]) self.assertEqual(0, subp.wait()) diff --git a/devstack/upgrade/upgrade.sh b/devstack/upgrade/upgrade.sh index ee4240b02d..929d0ead5e 100755 --- a/devstack/upgrade/upgrade.sh +++ b/devstack/upgrade/upgrade.sh @@ -67,8 +67,8 @@ upgrade_project ceilometer $RUN_DIR $BASE_DEVSTACK_BRANCH $TARGET_DEVSTACK_BRANC # Migrate the database # NOTE(chdent): As we evolve BIN_DIR is likely to be defined, but # currently it is not. -CEILOMETER_BIN_DIR=$(dirname $(which ceilometer-dbsync)) -$CEILOMETER_BIN_DIR/ceilometer-dbsync || die $LINENO "DB sync error" +CEILOMETER_BIN_DIR=$(dirname $(which ceilometer-upgrade)) +$CEILOMETER_BIN_DIR/ceilometer-upgrade --skip-gnocchi-resource-types || die $LINENO "ceilometer-upgrade error" # Start Ceilometer start_ceilometer diff --git a/doc/source/install/upgrade.rst b/doc/source/install/upgrade.rst index 7994b9eeca..d196eae7ab 100644 --- a/doc/source/install/upgrade.rst +++ b/doc/source/install/upgrade.rst @@ -31,12 +31,12 @@ one pass. 1. Upgrade the database (if applicable) - Run ceilometer-dbsync to upgrade the database if using one of Ceilometer's - databases (see :ref:`choosing_db_backend`). The database does not need to be - taken offline as no data is modified or deleted. Ideally this should be done - during a period of low activity. Best practices should still be followed - (ie. back up your data). If not using a Ceilometer database, you should - consult the documentation of that storage beforehand. + Run ceilometer-upgrade to upgrade the storage backend if using one of + Ceilometer's databases (see :ref:`choosing_db_backend`). The database does + not need to be taken offline. Ideally this should be done during a period of + low activity. Best practices should still be followed (ie. back up your + data). If not using a Ceilometer database, you should consult the + documentation of that storage beforehand. 2. Upgrade the collector service(s) diff --git a/releasenotes/notes/remove-ceilometer-dbsync-53aa1b529f194f15.yaml b/releasenotes/notes/remove-ceilometer-dbsync-53aa1b529f194f15.yaml new file mode 100644 index 0000000000..b2c46db5a4 --- /dev/null +++ b/releasenotes/notes/remove-ceilometer-dbsync-53aa1b529f194f15.yaml @@ -0,0 +1,4 @@ +--- +other: + - The deprecated ceilometer-dbsync has been removed. + Use ceilometer-upgrade instead. diff --git a/setup.cfg b/setup.cfg index b969206cf9..c201f5a0a0 100644 --- a/setup.cfg +++ b/setup.cfg @@ -259,7 +259,6 @@ console_scripts = ceilometer-polling = ceilometer.cmd.polling:main ceilometer-agent-notification = ceilometer.cmd.agent_notification:main ceilometer-send-sample = ceilometer.cmd.sample:send_sample - ceilometer-dbsync = ceilometer.cmd.storage:dbsync ceilometer-upgrade = ceilometer.cmd.storage:upgrade ceilometer-db-legacy-clean = ceilometer.cmd.storage:db_clean_legacy ceilometer-expirer = ceilometer.cmd.storage:expirer