openstack/ceilometer
Code Issues Proposed changes

compute: remove default duration value

Browse Source 
The default duration value is used only in test.
We can miss bug when test have a small diff with runtime.

So this change removes the default duration at runtime and fixes the
tests.

Change-Id: I2637facbd67fb81b995e9c9a7e4c092acfa06fcb
This commit is contained in:
Mehdi Abaakouk
2017-03-31 10:26:42 +02:00
parent 1e473dd45d
commit f21a4bcb26
8 changed files with 51 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
ceilometer/compute/virt/libvirt/inspector.py
View File

@@ -76,7 +76,7 @@ class LibvirtInspector(virt_inspector.Inspector):
return domain
@libvirt_utils.retry_on_disconnect
def inspect_vnics(self, instance, duration=None):
def inspect_vnics(self, instance, duration):
domain = self._get_domain_not_shut_off_or_raise(instance)
tree = etree.fromstring(domain.XMLDesc(0))
@@ -112,7 +112,7 @@ class LibvirtInspector(virt_inspector.Inspector):
tx_errors=dom_stats[7])
@libvirt_utils.retry_on_disconnect
def inspect_disks(self, instance, duration=None):
def inspect_disks(self, instance, duration):
domain = self._get_domain_not_shut_off_or_raise(instance)
tree = etree.fromstring(domain.XMLDesc(0))
@@ -129,7 +129,7 @@ class LibvirtInspector(virt_inspector.Inspector):
errors=block_stats[4])
@libvirt_utils.retry_on_disconnect
def inspect_disk_info(self, instance, duration=None):
def inspect_disk_info(self, instance, duration):
domain = self._get_domain_not_shut_off_or_raise(instance)
tree = etree.fromstring(domain.XMLDesc(0))
for disk in tree.findall('devices/disk'):