From 2948e2e900470b22b21bc9231ad12aa6dd5e61bf Mon Sep 17 00:00:00 2001 From: Takashi Kajinami Date: Mon, 14 Apr 2025 13:12:28 +0900 Subject: [PATCH] Run pyupgrade to clean up Python 2 syntaxes Python 2 support was removed long ago so we can clean up the syntaxes to support it. Change-Id: Ic7afb8cec6e4bd74f3b1b22d8ff27c45972a5b94 --- .pre-commit-config.yaml | 5 +++++ ceilometermiddleware/__init__.py | 2 -- ceilometermiddleware/swift.py | 6 +++--- ceilometermiddleware/tests/base.py | 2 -- ceilometermiddleware/tests/test_swift.py | 11 +++++------ doc/source/conf.py | 1 - releasenotes/source/conf.py | 4 ++-- 7 files changed, 15 insertions(+), 16 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index d174849..31d9d64 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -23,3 +23,8 @@ repos: hooks: - id: hacking additional_dependencies: [] + - repo: https://github.com/asottile/pyupgrade + rev: v3.18.0 + hooks: + - id: pyupgrade + args: [--py3-only] diff --git a/ceilometermiddleware/__init__.py b/ceilometermiddleware/__init__.py index f5cdc8c..654fc96 100644 --- a/ceilometermiddleware/__init__.py +++ b/ceilometermiddleware/__init__.py @@ -1,5 +1,3 @@ -# -*- coding: utf-8 -*- - # Licensed under the Apache License, Version 2.0 (the "License"); you may # not use this file except in compliance with the License. You may obtain # a copy of the License at diff --git a/ceilometermiddleware/swift.py b/ceilometermiddleware/swift.py index 9e0082c..37b002c 100644 --- a/ceilometermiddleware/swift.py +++ b/ceilometermiddleware/swift.py @@ -100,7 +100,7 @@ def _log_and_ignore_error(fn): return wrapper -class InputProxy(object): +class InputProxy: """File-like object that counts bytes read. To be swapped in for wsgi.input for accounting purposes. @@ -147,7 +147,7 @@ class KeystoneClientLoader(ksa_adapter.Adapter): return ks_client.Client -class Swift(object): +class Swift: """Swift middleware used for counting requests.""" event_queue = None @@ -412,7 +412,7 @@ class Swift(object): class SendEventThread(threading.Thread): def __init__(self, notifier): - super(SendEventThread, self).__init__() + super().__init__() self.notifier = notifier def run(self): diff --git a/ceilometermiddleware/tests/base.py b/ceilometermiddleware/tests/base.py index 1c30cdb..2159808 100644 --- a/ceilometermiddleware/tests/base.py +++ b/ceilometermiddleware/tests/base.py @@ -1,5 +1,3 @@ -# -*- coding: utf-8 -*- - # Copyright 2010-2011 OpenStack Foundation # Copyright (c) 2013 Hewlett-Packard Development Company, L.P. # diff --git a/ceilometermiddleware/tests/test_swift.py b/ceilometermiddleware/tests/test_swift.py index 43e0835..2d270f0 100644 --- a/ceilometermiddleware/tests/test_swift.py +++ b/ceilometermiddleware/tests/test_swift.py @@ -24,7 +24,7 @@ from ceilometermiddleware.tests import base as tests_base from keystoneauth1.fixture import keystoneauth_betamax as betamax -class FakeApp(object): +class FakeApp: def __init__(self, body=None): self.body = body or ['This string is 28 bytes long'] @@ -36,11 +36,10 @@ class FakeApp(object): ]) while env['wsgi.input'].read(5): pass - for line in self.body: - yield line + yield from self.body -class FakeRequest(object): +class FakeRequest: """A bare bones request object The middleware will inspect this for request method, @@ -65,7 +64,7 @@ class FakeRequest(object): class TestSwift(tests_base.TestCase): def setUp(self): - super(TestSwift, self).setUp() + super().setUp() cfg.CONF([], project='ceilometermiddleware') self.addCleanup(cfg.CONF.reset) @@ -261,7 +260,7 @@ class TestSwift(tests_base.TestCase): app = swift.Swift(FakeApp(), { 'metadata_headers': 'unicode' }) - uni = u'\xef\xbd\xa1\xef\xbd\xa5' + uni = '\xef\xbd\xa1\xef\xbd\xa5' req = self.get_request('/1.0/account/container', environ={'REQUEST_METHOD': 'GET'}, headers={'UNICODE': uni}) diff --git a/doc/source/conf.py b/doc/source/conf.py index e383948..51ad808 100644 --- a/doc/source/conf.py +++ b/doc/source/conf.py @@ -1,4 +1,3 @@ -# -*- coding: utf-8 -*- # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at diff --git a/releasenotes/source/conf.py b/releasenotes/source/conf.py index d3ca192..a238094 100644 --- a/releasenotes/source/conf.py +++ b/releasenotes/source/conf.py @@ -54,8 +54,8 @@ master_doc = 'index' # General information about the project. author = 'Ceilometer Middleware Contributors' category = 'Miscellaneous' -copyright = u'2016, Ceilometer Middleware Developers' -project = u'Ceilometer Middleware Release Notes' +copyright = '2016, Ceilometer Middleware Developers' +project = 'Ceilometer Middleware Release Notes' description = 'Ceilometer Middleware publishes traffic measures for Swift.' title = 'Ceilometer Middleware Release Notes' target_name = 'ceilometermiddleware'