8a162064db
The mock third party library was needed for mock support in py2 runtimes. Since we now only support py36 and later, we can use the standard lib unittest.mock module instead. Note that https://github.com/openstack/charms.openstack is used during tests and he need `mock`, unfortunatelly it doesn't declare `mock` in its requirements so it retrieve mock from other charm project (cross dependency). So we depend on charms.openstack first and when Ib1ed5b598a52375e29e247db9ab4786df5b6d142 will be merged then CI will pass without errors. Depends-On: Ib1ed5b598a52375e29e247db9ab4786df5b6d142 Change-Id: I2f54eb8f1fae913603f8692986361b88a32cc221
172 lines
5.4 KiB
Python
172 lines
5.4 KiB
Python
# Copyright 2016 Canonical Ltd
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
from unittest import mock
|
|
|
|
import charms_openstack.test_utils as test_utils
|
|
|
|
import charm.openstack.barbican as barbican
|
|
|
|
|
|
class Helper(test_utils.PatchHelper):
|
|
|
|
def setUp(self):
|
|
super().setUp()
|
|
self.patch_release(barbican.BarbicanCharm.release)
|
|
|
|
|
|
class TestHSMProperties(Helper):
|
|
|
|
def setUp(self):
|
|
super().setUp()
|
|
self.data_none = {}
|
|
self.data_set = {
|
|
'library_path': 'a-path',
|
|
'login': 'a-login',
|
|
'slot_id': 'a-slot_id',
|
|
}
|
|
|
|
def test_library_path(self):
|
|
hsm = mock.MagicMock()
|
|
hsm.relation.plugin_data = self.data_none
|
|
self.assertEqual(barbican.library_path(hsm), '')
|
|
hsm.relation.plugin_data = self.data_set
|
|
self.assertEqual(barbican.library_path(hsm), 'a-path')
|
|
|
|
def test_login(self):
|
|
hsm = mock.MagicMock()
|
|
hsm.relation.plugin_data = self.data_none
|
|
self.assertEqual(barbican.login(hsm), '')
|
|
hsm.relation.plugin_data = self.data_set
|
|
self.assertEqual(barbican.login(hsm), 'a-login')
|
|
|
|
def test_slot_id(self):
|
|
hsm = mock.MagicMock()
|
|
hsm.relation.plugin_data = self.data_none
|
|
self.assertEqual(barbican.slot_id(hsm), '')
|
|
hsm.relation.plugin_data = self.data_set
|
|
self.assertEqual(barbican.slot_id(hsm), 'a-slot_id')
|
|
|
|
|
|
class TestSecretsProperties(Helper):
|
|
|
|
def test_plugins(self):
|
|
secrets = mock.MagicMock()
|
|
plugins = {'name': 'a-name'}
|
|
secrets.relation.plugins = plugins
|
|
self.assertEqual(barbican.plugins(secrets), plugins)
|
|
|
|
def test_plugins_string(self):
|
|
secrets = mock.MagicMock()
|
|
plugins_string = 'a-name_plugin'
|
|
secrets.relation.plugins_string = plugins_string
|
|
self.assertEqual(barbican.plugins_string(secrets), plugins_string)
|
|
|
|
|
|
class TestBarbicanCharm(Helper):
|
|
|
|
def test_action_generate_mkek(self):
|
|
hsm = mock.MagicMock()
|
|
hsm.plugin_data = {
|
|
'library_path': 'path1',
|
|
'login': '1234',
|
|
'slot_id': 'slot1'
|
|
}
|
|
self.patch_object(barbican.hookenv, 'config')
|
|
config = {
|
|
'mkek-key-length': 5,
|
|
'label-mkek': 'the-label'
|
|
}
|
|
|
|
def cf(key=None):
|
|
if key is not None:
|
|
return config[key]
|
|
return config
|
|
|
|
self.config.side_effect = cf
|
|
self.patch_object(barbican.subprocess, 'check_call')
|
|
self.patch_object(barbican.hookenv, 'log')
|
|
# try generating a an mkek with no failure
|
|
c = barbican.BarbicanCharm()
|
|
c.action_generate_mkek(hsm)
|
|
cmd = [
|
|
'barbican-manage', 'hsm', 'gen_mkek',
|
|
'--library-path', 'path1',
|
|
'--passphrase', '1234',
|
|
'--slot-id', 'slot1',
|
|
'--length', '5',
|
|
'--label', 'the-label',
|
|
]
|
|
self.check_call.assert_called_once_with(cmd)
|
|
self.log.assert_called_once_with(
|
|
"barbican-mangage hsm gen_mkek succeeded")
|
|
# and check that a problem is logged if it goes wrong
|
|
|
|
def side_effect():
|
|
raise barbican.subprocess.CalledProcessError
|
|
|
|
self.check_call.side_effect = side_effect
|
|
self.log.reset_mock()
|
|
with self.assertRaises(Exception):
|
|
c.action_generate_mkek(hsm)
|
|
self.log.assert_called_once_with(
|
|
"barbican-manage hsm gen_mkek failed.")
|
|
|
|
def test_action_generate_hmac(self):
|
|
hsm = mock.MagicMock()
|
|
hsm.plugin_data = {
|
|
'library_path': 'path1',
|
|
'login': '1234',
|
|
'slot_id': 'slot1'
|
|
}
|
|
self.patch_object(barbican.hookenv, 'config')
|
|
config = {
|
|
'hmac-key-length': 5,
|
|
'label-hmac': 'the-label'
|
|
}
|
|
|
|
def cf(key=None):
|
|
if key is not None:
|
|
return config[key]
|
|
return config
|
|
|
|
self.config.side_effect = cf
|
|
self.patch_object(barbican.subprocess, 'check_call')
|
|
self.patch_object(barbican.hookenv, 'log')
|
|
# try generating a an hmac with no failure
|
|
c = barbican.BarbicanCharm()
|
|
c.action_generate_hmac(hsm)
|
|
cmd = [
|
|
'barbican-manage', 'hsm', 'gen_hmac',
|
|
'--library-path', 'path1',
|
|
'--passphrase', '1234',
|
|
'--slot-id', 'slot1',
|
|
'--length', '5',
|
|
'--label', 'the-label',
|
|
]
|
|
self.check_call.assert_called_once_with(cmd)
|
|
self.log.assert_called_once_with(
|
|
"barbican-mangage hsm gen_hmac succeeded")
|
|
# and check that a problem is logged if it goes wrong
|
|
|
|
def side_effect():
|
|
raise barbican.subprocess.CalledProcessError
|
|
|
|
self.check_call.side_effect = side_effect
|
|
self.log.reset_mock()
|
|
with self.assertRaises(Exception):
|
|
c.action_generate_hmac(hsm)
|
|
self.log.assert_called_once_with(
|
|
"barbican-manage hsm gen_hmac failed.")
|