43a2312794
This is a subordinate charm and since a recent commit [1] it shares a list of its services with the principal charm nova-compute, which has now the responsibility to pause and resume services. [2] The ceilometer-agent-compute service has a dependency to the nova-compute service anyway, so it is impossible for this charm to resume its service if its principal charm nova-compute is paused. This is what also led to errors in ceilometer-agent's post-series-upgrade hook. This hook attempted to resume its service although the principal service was still paused. Removing this logic entirely solves this issue. Validated by running openstack-upgrade and series-upgrade tests. [3] [1]: https://opendev.org/openstack/charm-ceilometer-agent/commit/be45f779 [2]: https://opendev.org/openstack/charm-nova-compute/commit/8fb37dc0 [3]: https://github.com/openstack-charmers/charmed-openstack-tester Closes-Bug: #1952882 Change-Id: Ia22b53b52b541250f7f803c6708968d75e64475c
178 lines
5.2 KiB
Python
Executable File
178 lines
5.2 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
#
|
|
# Copyright 2016 Canonical Ltd
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
import json
|
|
import os
|
|
import sys
|
|
|
|
_path = os.path.dirname(os.path.realpath(__file__))
|
|
_root = os.path.abspath(os.path.join(_path, '..'))
|
|
|
|
|
|
def _add_path(path):
|
|
if path not in sys.path:
|
|
sys.path.insert(1, path)
|
|
|
|
|
|
_add_path(_root)
|
|
|
|
|
|
from charmhelpers.fetch import (
|
|
apt_install, filter_installed_packages,
|
|
apt_update
|
|
)
|
|
from charmhelpers.core.hookenv import (
|
|
Hooks, UnregisteredHookError,
|
|
log,
|
|
is_relation_made,
|
|
relation_set,
|
|
status_set,
|
|
relation_ids,
|
|
config,
|
|
)
|
|
from charmhelpers.core.host import (
|
|
service_restart
|
|
)
|
|
from charmhelpers.contrib.openstack.utils import (
|
|
pausable_restart_on_change as restart_on_change,
|
|
)
|
|
from ceilometer_utils import (
|
|
restart_map,
|
|
services,
|
|
register_configs,
|
|
NOVA_SETTINGS,
|
|
assess_status,
|
|
get_packages,
|
|
releases_packages_map,
|
|
remove_old_packages,
|
|
)
|
|
from charmhelpers.contrib.charmsupport import nrpe
|
|
|
|
hooks = Hooks()
|
|
CONFIGS = register_configs()
|
|
|
|
|
|
@hooks.hook('install.real')
|
|
def install():
|
|
status_set('maintenance', 'Installing apt packages')
|
|
apt_update(fatal=True)
|
|
# Install -common package so we get accurate version determination
|
|
apt_install(filter_installed_packages(['ceilometer-common']),
|
|
fatal=True)
|
|
apt_install(
|
|
filter_installed_packages(get_packages()),
|
|
fatal=True)
|
|
|
|
|
|
@hooks.hook('nova-ceilometer-relation-joined')
|
|
def nova_ceilometer_joined(relation_id=None):
|
|
relation_set(
|
|
relation_id=relation_id,
|
|
relation_settings={
|
|
'subordinate_configuration': json.dumps(NOVA_SETTINGS),
|
|
'releases-packages-map': json.dumps(
|
|
releases_packages_map(), sort_keys=True),
|
|
'services': json.dumps(services())
|
|
})
|
|
|
|
|
|
@hooks.hook("ceilometer-service-relation-changed")
|
|
@restart_on_change(restart_map())
|
|
def ceilometer_changed():
|
|
CONFIGS.write_all()
|
|
if is_relation_made('nrpe-external-master'):
|
|
update_nrpe_config()
|
|
|
|
|
|
@hooks.hook("upgrade-charm")
|
|
def upgrade_charm():
|
|
apt_install(
|
|
filter_installed_packages(get_packages()),
|
|
fatal=True)
|
|
|
|
packages_removed = remove_old_packages()
|
|
if packages_removed:
|
|
# NOTE(lourot): this code path is run when python2 packages have been
|
|
# purged and python3 packages installed. In this case it is best to
|
|
# restart the ceilometer-agent-compute service.
|
|
log("Package purge detected, restarting services", "INFO")
|
|
for s in services():
|
|
# NOTE(lourot): if the principal nova-compute unit is paused, the
|
|
# ceilometer-agent-compute service, depending on the nova-compute
|
|
# service, will refuse to start, but this call won't raise. It'll
|
|
# just return False. This can safely be ignored: all services will
|
|
# finally be started when unpausing nova-compute.
|
|
service_restart(s)
|
|
|
|
# NOTE(jamespage): Ensure any changes to nova presented data are made
|
|
# during charm upgrades.
|
|
for rid in relation_ids('nova-ceilometer'):
|
|
nova_ceilometer_joined(rid)
|
|
|
|
|
|
@hooks.hook('nova-ceilometer-relation-changed')
|
|
@hooks.hook('config-changed')
|
|
@restart_on_change(restart_map(), stopstart=True)
|
|
def config_changed():
|
|
apt_install(filter_installed_packages(get_packages()), fatal=True)
|
|
if is_relation_made('nrpe-external-master'):
|
|
update_nrpe_config()
|
|
CONFIGS.write_all()
|
|
|
|
|
|
@hooks.hook('nrpe-external-master-relation-joined',
|
|
'nrpe-external-master-relation-changed')
|
|
def update_nrpe_config():
|
|
# python-dbus is used by check_upstart_job
|
|
apt_install('python-dbus')
|
|
hostname = nrpe.get_nagios_hostname()
|
|
current_unit = nrpe.get_nagios_unit_name()
|
|
nrpe_setup = nrpe.NRPE(hostname=hostname)
|
|
nrpe.add_init_service_checks(nrpe_setup, services(), current_unit)
|
|
nrpe_setup.write()
|
|
|
|
|
|
@hooks.hook('amqp-relation-joined')
|
|
def amqp_joined(relation_id=None):
|
|
relation_set(relation_id=relation_id,
|
|
username=config('rabbit-user'),
|
|
vhost=config('rabbit-vhost'))
|
|
|
|
|
|
@hooks.hook('update-status')
|
|
def dummy_update_status():
|
|
"""Dummy function to silence missing hook log entry"""
|
|
pass
|
|
|
|
|
|
@hooks.hook('amqp-relation-changed',
|
|
'amqp-relation-departed')
|
|
@restart_on_change(restart_map())
|
|
def amqp_changed():
|
|
if 'amqp' not in CONFIGS.complete_contexts():
|
|
log('amqp relation incomplete. Peer not ready?')
|
|
return
|
|
CONFIGS.write_all()
|
|
|
|
|
|
if __name__ == '__main__':
|
|
try:
|
|
hooks.execute(sys.argv)
|
|
except UnregisteredHookError as e:
|
|
log('Unknown hook {} - skipping.'.format(e))
|
|
# set_os_workload_status(CONFIGS, REQUIRED_INTERFACES)
|
|
assess_status(CONFIGS)
|