openstack
/
charm-ceph-fs
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(2 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 33717 \u003c33717@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_15382\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 15382 \u003c15382@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_15382\u003e replied on the change"}
This commit is contained in:
Gerrit User 15382 2024-04-24 14:30:01 +00:00 committed by Gerrit Code Review
parent 72a142d851
commit 64c264c214
1 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
1693f63e7b14708ad3de2c866dfeb43aceeef430
View File

@ -86,6 +86,24 @@
"revId": "1693f63e7b14708ad3de2c866dfeb43aceeef430",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "2e00396d_44bcd3a9",
"filename": "src/reactive/ceph_fs.py",
"patchSetId": 3
},
"lineNbr": 44,
"author": {
"id": 15382
},
"writtenOn": "2024-04-24T14:30:01Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "1d33090c_3a1e23be",
"revId": "1693f63e7b14708ad3de2c866dfeb43aceeef430",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -121,6 +139,24 @@
"revId": "1693f63e7b14708ad3de2c866dfeb43aceeef430",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e4cf8d40_6674d9f0",
"filename": "src/reactive/ceph_fs.py",
"patchSetId": 3
},
"lineNbr": 62,
"author": {
"id": 15382
},
"writtenOn": "2024-04-24T14:30:01Z",
"side": 1,
"message": "\u003e It checks if the keyring file existed before this call. If it did, this was a key rotation, otherwise it\u0027s the basic key setup.\n\nOk, so this means there\u0027s no other cases where the relation would change is that correct?",
"parentUuid": "251d1a26_f33c9627",
"revId": "1693f63e7b14708ad3de2c866dfeb43aceeef430",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {