From 0dd383d35134bea7b4146fd8277b22ab5d27c2ac Mon Sep 17 00:00:00 2001 From: Chris MacNaughton Date: Mon, 3 Oct 2016 13:16:30 -0400 Subject: [PATCH] Remove the compiled python bytecode upgrade-charm could previously fail because of compiled bytecode remaining behind. This change makes the upgrade-charm hook remove any such compiled bytecode files Closes-Bug: 1628322 Change-Id: I3886b514b47d6fc9fdfb350e2b3a2296472e40f6 --- hooks/ceph_hooks.py | 2 +- hooks/upgrade-charm | 7 ++++++- hooks/upgrade-charm.real | 1 + 3 files changed, 8 insertions(+), 2 deletions(-) mode change 120000 => 100755 hooks/upgrade-charm create mode 120000 hooks/upgrade-charm.real diff --git a/hooks/ceph_hooks.py b/hooks/ceph_hooks.py index 68867027..04db92b4 100755 --- a/hooks/ceph_hooks.py +++ b/hooks/ceph_hooks.py @@ -446,7 +446,7 @@ def mon_relation(): log('mon cluster has not yet provided conf') -@hooks.hook('upgrade-charm') +@hooks.hook('upgrade-charm.real') @harden() def upgrade_charm(): if get_fsid() and get_auth(): diff --git a/hooks/upgrade-charm b/hooks/upgrade-charm deleted file mode 120000 index 52d96630..00000000 --- a/hooks/upgrade-charm +++ /dev/null @@ -1 +0,0 @@ -ceph_hooks.py \ No newline at end of file diff --git a/hooks/upgrade-charm b/hooks/upgrade-charm new file mode 100755 index 00000000..440473d7 --- /dev/null +++ b/hooks/upgrade-charm @@ -0,0 +1,6 @@ +#!/bin/bash +# Wrapper to ensure that old python bytecode isn't hanging around +# after we upgrade the charm with newer libraries +rm -rf **/*.pyc + +exec ./hooks/upgrade-charm.real diff --git a/hooks/upgrade-charm.real b/hooks/upgrade-charm.real new file mode 120000 index 00000000..52d96630 --- /dev/null +++ b/hooks/upgrade-charm.real @@ -0,0 +1 @@ +ceph_hooks.py \ No newline at end of file