From 141b49d9bbe6f6811c1a9d9060c538ea5be8529d Mon Sep 17 00:00:00 2001 From: Gerrit User 34352 <34352@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Fri, 15 Sep 2023 03:00:40 +0000 Subject: [PATCH] Update patch set 1 Patch Set 1: (1 comment) Patch-set: 1 --- 23db141218d8a3cd0ff506f2a05c60db484034aa | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/23db141218d8a3cd0ff506f2a05c60db484034aa b/23db141218d8a3cd0ff506f2a05c60db484034aa index c40c49aa..e33db2b9 100644 --- a/23db141218d8a3cd0ff506f2a05c60db484034aa +++ b/23db141218d8a3cd0ff506f2a05c60db484034aa @@ -16,6 +16,23 @@ "message": "This is a follow-up to https://review.opendev.org/c/openstack/charm-ceph-osd/+/869619/", "revId": "23db141218d8a3cd0ff506f2a05c60db484034aa", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, + { + "unresolved": true, + "key": { + "uuid": "c4c8203c_33272995", + "filename": "hooks/ceph_hooks.py", + "patchSetId": 1 + }, + "lineNbr": 441, + "author": { + "id": 34352 + }, + "writtenOn": "2023-09-15T03:00:40Z", + "side": 1, + "message": "Not sure how pythonic all this is, but it was fun playing with enums. The alternative I guess would be to add a `is_valid_tune_osd_memory_target() -\u003e bool` function, but feels like repeating logic.", + "revId": "23db141218d8a3cd0ff506f2a05c60db484034aa", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" } ] } \ No newline at end of file