openstack
/
charm-ceph-osd
Code Issues Proposed changes

Update patch set 7 

Patch Set 7:

(2 comments)

Patch-set: 7
Attention: {"person_ident":"Gerrit User 36857 \u003c36857@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_36857\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 15382 \u003c15382@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_36857\u003e replied on the change"}
This commit is contained in:
Gerrit User 36857 2024-04-09 12:04:44 +00:00 committed by Gerrit Code Review
parent f3f32c8e63
commit a1f2f6e96b
2 changed files with 36 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
5d0ddb915fdf4eff2e6f2d770de5a42486e252fb
View File

@ -85,6 +85,24 @@
"parentUuid": "4ffd52a5_c6ba2a90",
"revId": "5d0ddb915fdf4eff2e6f2d770de5a42486e252fb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ac47f17a_13adcc5b",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 4
},
"lineNbr": 0,
"author": {
"id": 36857
},
"writtenOn": "2024-04-09T12:04:44Z",
"side": 1,
"message": "Acknowledged",
"parentUuid": "1e894435_b2dfe038",
"revId": "5d0ddb915fdf4eff2e6f2d770de5a42486e252fb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

18
a354c3cd5b2488db00134f8393bbd1be21ccdbfb
View File

@ -34,6 +34,24 @@
"parentUuid": "846861d4_7fbfbd7c",
"revId": "a354c3cd5b2488db00134f8393bbd1be21ccdbfb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "1f0700ad_38f9f8b7",
"filename": "unit_tests/test_ceph_hooks.py",
"patchSetId": 6
},
"lineNbr": 438,
"author": {
"id": 36857
},
"writtenOn": "2024-04-09T12:04:44Z",
"side": 1,
"message": "Sounds good. I\u0027ll resolve the other comment threads.\nThe Zuul build fails because we are putting mock objects inside other mock objects in the tests, so I\u0027d ignore the py311 build.",
"parentUuid": "069806b9_f5436137",
"revId": "a354c3cd5b2488db00134f8393bbd1be21ccdbfb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}