openstack
/
charm-ceph-osd
Code Issues Proposed changes

Update patch set 3 

Patch Set 3:

(3 comments)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 33717 \u003c33717@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_34352\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 15382 \u003c15382@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_34352\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 34352 \u003c34352@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_34352\u003e replied on the change"}
This commit is contained in:
Gerrit User 34352 2023-09-29 04:12:05 +00:00 committed by Gerrit Code Review
parent 7650733a9c
commit c919a0b884
1 changed files with 54 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

54
23db141218d8a3cd0ff506f2a05c60db484034aa
View File

@ -34,6 +34,24 @@
"revId": "23db141218d8a3cd0ff506f2a05c60db484034aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "01e89a7d_441603df",
"filename": "hooks/ceph_hooks.py",
"patchSetId": 1
},
"lineNbr": 398,
"author": {
"id": 34352
},
"writtenOn": "2023-09-29T04:12:05Z",
"side": 1,
"message": "Ack",
"parentUuid": "c3ea78ad_76bf264c",
"revId": "23db141218d8a3cd0ff506f2a05c60db484034aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -51,6 +69,24 @@
"revId": "23db141218d8a3cd0ff506f2a05c60db484034aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "22977c99_1f85e641",
"filename": "hooks/ceph_hooks.py",
"patchSetId": 1
},
"lineNbr": 412,
"author": {
"id": 34352
},
"writtenOn": "2023-09-29T04:12:05Z",
"side": 1,
"message": "Done",
"parentUuid": "ebb40201_1adf1b0c",
"revId": "23db141218d8a3cd0ff506f2a05c60db484034aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
@ -85,6 +121,24 @@
"parentUuid": "c4c8203c_33272995",
"revId": "23db141218d8a3cd0ff506f2a05c60db484034aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "1c36132e_f44df22b",
"filename": "hooks/ceph_hooks.py",
"patchSetId": 1
},
"lineNbr": 441,
"author": {
"id": 34352
},
"writtenOn": "2023-09-29T04:12:05Z",
"side": 1,
"message": "Ok, I dropped the playing with enums and namedtuples because it was getting too complicated. Please see the latest update which adds a simple function to check validity in assess status.",
"parentUuid": "0256237c_83a1a6e5",
"revId": "23db141218d8a3cd0ff506f2a05c60db484034aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}