charm-ceph-proxy/832d6bb84e35894bd2d20f48fe3...

250 lines
8.2 KiB
Plaintext

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "1c2baced_35d20700",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 15382
},
"writtenOn": "2023-04-26T09:04:06Z",
"side": 1,
"message": "Added a Q wrt to using channel\u003dlatest for dependencies",
"revId": "832d6bb84e35894bd2d20f48fe36a2429ff847a9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "dcd29d35_9874d8f8",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 2
},
"lineNbr": 0,
"author": {
"id": 15382
},
"writtenOn": "2023-04-28T10:41:07Z",
"side": 1,
"message": "Hey, just added some additional comments and Q :-)",
"revId": "832d6bb84e35894bd2d20f48fe36a2429ff847a9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c93a0ae4_4baf71ec",
"filename": "osci.yaml",
"patchSetId": 2
},
"lineNbr": 14,
"author": {
"id": 15382
},
"writtenOn": "2023-04-28T10:41:07Z",
"side": 1,
"message": "Should be voting: true IMHO",
"revId": "832d6bb84e35894bd2d20f48fe36a2429ff847a9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "a6629ced_b4f6e237",
"filename": "tests/bundles/jammy-antelope.yaml",
"patchSetId": 2
},
"lineNbr": 2,
"author": {
"id": 15382
},
"writtenOn": "2023-04-28T10:41:07Z",
"side": 1,
"message": "Unsure, should this be distro or jammy-antelope?",
"revId": "832d6bb84e35894bd2d20f48fe36a2429ff847a9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "68ba98c7_f13d9ad4",
"filename": "tests/bundles/jammy-antelope.yaml",
"patchSetId": 2
},
"lineNbr": 33,
"author": {
"id": 15382
},
"writtenOn": "2023-04-26T09:04:06Z",
"side": 1,
"message": "I wonder about using latest/edge as a channel here and below. Would it be safer to reference antelope/edge here for a future where latest points to \u0027B\u0027? \n\nI notice that our handling of this across test bundles and charms is not consistent unfortunately",
"revId": "832d6bb84e35894bd2d20f48fe36a2429ff847a9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1f0bf1be_7a679283",
"filename": "tests/bundles/jammy-antelope.yaml",
"patchSetId": 2
},
"lineNbr": 33,
"author": {
"id": 33717
},
"writtenOn": "2023-04-26T14:06:35Z",
"side": 1,
"message": "Good point. I think we should handle these \u0027reactively\u0027 (i.e: fix as we go). I\u0027ll change these (though I\u0027ll use 2023.1/edge since antelope isn\u0027t out yet)",
"parentUuid": "68ba98c7_f13d9ad4",
"revId": "832d6bb84e35894bd2d20f48fe36a2429ff847a9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "13496087_c55d37fd",
"filename": "tests/bundles/jammy-antelope.yaml",
"patchSetId": 2
},
"lineNbr": 33,
"author": {
"id": 15382
},
"writtenOn": "2023-04-28T10:41:07Z",
"side": 1,
"message": "We\u0027d need to use a non-openstack track name -- but in light of recent discussions for the non-openstack charms latest/edge should probably work as well, since the API should stay the same",
"parentUuid": "1f0bf1be_7a679283",
"revId": "832d6bb84e35894bd2d20f48fe36a2429ff847a9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "091eaa2f_24fe3106",
"filename": "tests/bundles/lunar-antelope-ec.yaml",
"patchSetId": 2
},
"lineNbr": 2,
"author": {
"id": 15382
},
"writtenOn": "2023-04-28T10:41:07Z",
"side": 1,
"message": "We\u0027d want to make this lunar-antelope instead of distro",
"revId": "832d6bb84e35894bd2d20f48fe36a2429ff847a9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
],
"submitRequirementResults": [
{
"submitRequirement": {
"name": "Backport-Candidate",
"description": {
"value": "Backport candidate status"
},
"applicabilityExpression": {
"value": {
"expressionString": "is:false"
}
},
"submittabilityExpression": {
"expressionString": "is:true"
},
"overrideExpression": {},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {
"value": {"expression":{"expressionString":"is:false"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["is:false"]}
},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"is:true"},"status":"NOT_EVALUATED","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":[]}
},
"overrideExpressionResult": {},
"patchSetCommitId": "832d6bb84e35894bd2d20f48fe36a2429ff847a9",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "Code-Review",
"description": {
"value": "Code reviewed by core reviewer"
},
"applicabilityExpression": {},
"submittabilityExpression": {
"expressionString": "label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN"
},
"overrideExpression": {},
"allowOverrideInChildProjects": true
},
"applicabilityExpressionResult": {},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"label:Code-Review=MAX AND -label:Code-Review=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Code-Review=MAX","label:Code-Review=MIN"]}
},
"overrideExpressionResult": {},
"patchSetCommitId": "832d6bb84e35894bd2d20f48fe36a2429ff847a9",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "Verified",
"description": {
"value": "Verified in gate by CI"
},
"applicabilityExpression": {},
"submittabilityExpression": {
"expressionString": "label:Verified\u003dMAX AND -label:Verified\u003dMIN"
},
"overrideExpression": {},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"label:Verified=MAX AND -label:Verified=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Verified=MAX","label:Verified=MIN"]}
},
"overrideExpressionResult": {},
"patchSetCommitId": "832d6bb84e35894bd2d20f48fe36a2429ff847a9",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
},
{
"submitRequirement": {
"name": "Workflow",
"description": {
"value": "Approved for gate by core reviewer"
},
"applicabilityExpression": {},
"submittabilityExpression": {
"expressionString": "label:Workflow\u003dMAX AND -label:Workflow\u003dMIN"
},
"overrideExpression": {},
"allowOverrideInChildProjects": false
},
"applicabilityExpressionResult": {},
"submittabilityExpressionResult": {
"value": {"expression":{"expressionString":"label:Workflow=MAX AND -label:Workflow=MIN"},"status":"FAIL","errorMessage":{"value":null},"passingAtoms":[],"failingAtoms":["label:Workflow=MAX","label:Workflow=MIN"]}
},
"overrideExpressionResult": {},
"patchSetCommitId": "832d6bb84e35894bd2d20f48fe36a2429ff847a9",
"legacy": {
"value": false
},
"forced": {},
"hidden": {}
}
]
}