Update pre-install hooks to fail on error
The pre-install operations may fail, yet that failure is not elevated to the user. This masks the failure and makes early package install issues difficult to troubleshoot. If the basic pre-install script fails, the charm should not proceed to later hooks as the requirements may not be met. Hashbangs for bash should specify -e (errexit) on all of the pre-install bash scripts. Change-Id: Ie7b99dfa4cbe00a03acf1b2cc2eeecc7f84fbe17 Closes-bug: #1815243 Partial-bug: #1815231
This commit is contained in:
parent
2eef15113f
commit
c4e5565799
@ -1,4 +1,4 @@
|
||||
#!/bin/bash
|
||||
#!/bin/bash -e
|
||||
# Wrapper to deal with newer Ubuntu versions that don't have py2 installed
|
||||
# by default.
|
||||
|
||||
|
@ -1,4 +1,4 @@
|
||||
#!/bin/bash
|
||||
#!/bin/bash -e
|
||||
# Install required dependencies for charm runtime
|
||||
|
||||
declare -a DEPS=('apt' 'netaddr' 'netifaces' 'yaml' 'jinja2' 'dnspython')
|
||||
|
@ -1,4 +1,4 @@
|
||||
#!/bin/bash
|
||||
#!/bin/bash -e
|
||||
# Re-install dependencies to deal with py2->py3 switch for charm
|
||||
|
||||
./hooks/install_deps
|
||||
|
Loading…
Reference in New Issue
Block a user