openstack/charm-ceph-radosgw
Code Issues Proposed changes

Update pre-install hooks to fail on error

Browse Source 
The pre-install operations may fail, yet that failure is not
elevated to the user. This masks the failure and makes early
package install issues difficult to troubleshoot.

If the basic pre-install script fails, the charm should not
proceed to later hooks as the requirements may not be met.

Hashbangs for bash should specify -e (errexit) on all of the
pre-install bash scripts.

Change-Id: Ie7b99dfa4cbe00a03acf1b2cc2eeecc7f84fbe17
Closes-bug: #1815243
Partial-bug: #1815231
This commit is contained in:
Ryan Beisner 2019-02-08 15:10:21 -06:00
parent 2eef15113f
commit c4e5565799
No known key found for this signature in database
GPG Key ID: 952BACDC1C1A05FB
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hooks/install
View File

@ -1,4 +1,4 @@
#!/bin/bash #!/bin/bash -e
# Wrapper to deal with newer Ubuntu versions that don't have py2 installed # Wrapper to deal with newer Ubuntu versions that don't have py2 installed
# by default. # by default.

2
hooks/install_deps
View File

@ -1,4 +1,4 @@
#!/bin/bash #!/bin/bash -e
# Install required dependencies for charm runtime # Install required dependencies for charm runtime
declare -a DEPS=('apt' 'netaddr' 'netifaces' 'yaml' 'jinja2' 'dnspython') declare -a DEPS=('apt' 'netaddr' 'netifaces' 'yaml' 'jinja2' 'dnspython')

2
hooks/upgrade-charm
View File

@ -1,4 +1,4 @@
#!/bin/bash #!/bin/bash -e
# Re-install dependencies to deal with py2->py3 switch for charm # Re-install dependencies to deal with py2->py3 switch for charm
./hooks/install_deps ./hooks/install_deps