Update patch set 1
Patch Set 1: Code-Review-1
(7 comments)
Patch-set: 1
Reviewer: Gerrit User 20870 <20870@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
Attention: {"person_ident":"Gerrit User 11805 \u003c11805@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_20870\u003e replied on the change"}
This commit is contained in:
Gerrit User 20870
Gerrit Code Review
parent
43e0274d44
commit
4ee825af2c
|
|
@ -0,0 +1,159 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "204d322b_ba4ceeea",
|
||||
"filename": ".zuul.yaml",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 4,
|
||||
"author": {
|
||||
"id": 20870
|
||||
},
|
||||
"writtenOn": "2022-07-20T12:10:42Z",
|
||||
"side": 1,
|
||||
"message": "I\u0027ve not caught one of these before, but really the eventual \u0027zed\u0027 charm should only have openstack-python3-charm-zed-jobs and not yoga jobs, as the yoga jobs include py38 and (in theory) this charm doesn\u0027t need py38 anymore at master; i.e. it should be py3.10 only for jammy-yoga and jammy-zed. Does that make sense?",
|
||||
"range": {
|
||||
"startLine": 3,
|
||||
"startChar": 0,
|
||||
"endLine": 4,
|
||||
"endChar": 40
|
||||
},
|
||||
"revId": "b492c3c3ca3b81417d447a37eb13740cab6d58a7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "758b62f7_0a33196a",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 20870
|
||||
},
|
||||
"writtenOn": "2022-07-20T12:10:42Z",
|
||||
"side": 1,
|
||||
"message": "So it\u0027s probably worth discussing further, but the zed enablement is a great time to remove focal-yoga from the charm as focal no longer needs to be supported. This means that the charm needs to build on 22.04 and only needs to target 22.04 in the eventual stable/zed branch (and thus zed track).",
|
||||
"revId": "b492c3c3ca3b81417d447a37eb13740cab6d58a7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "c434c2dd_cad26735",
|
||||
"filename": "charmcraft.yaml",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 26,
|
||||
"author": {
|
||||
"id": 20870
|
||||
},
|
||||
"writtenOn": "2022-07-20T12:10:42Z",
|
||||
"side": 1,
|
||||
"message": "The build on should be 22.04 as the charm only needs to support jammy when it becomes zed. i.e. yoga was the last version that supported focal.",
|
||||
"range": {
|
||||
"startLine": 23,
|
||||
"startChar": 0,
|
||||
"endLine": 26,
|
||||
"endChar": 17
|
||||
},
|
||||
"revId": "b492c3c3ca3b81417d447a37eb13740cab6d58a7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "ca8299e3_852e44f6",
|
||||
"filename": "charmcraft.yaml",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 30,
|
||||
"author": {
|
||||
"id": 20870
|
||||
},
|
||||
"writtenOn": "2022-07-20T12:10:42Z",
|
||||
"side": 1,
|
||||
"message": "20.04 can be dropped for jammy-zed, as the charm will only support jammy-yoga and jammy-zed.",
|
||||
"range": {
|
||||
"startLine": 28,
|
||||
"startChar": 0,
|
||||
"endLine": 30,
|
||||
"endChar": 53
|
||||
},
|
||||
"revId": "b492c3c3ca3b81417d447a37eb13740cab6d58a7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "c388712e_0d73046b",
|
||||
"filename": "metadata.yaml",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 11,
|
||||
"author": {
|
||||
"id": 20870
|
||||
},
|
||||
"writtenOn": "2022-07-20T12:10:42Z",
|
||||
"side": 1,
|
||||
"message": "remove focal, as the charm no longer needs to support focal.",
|
||||
"range": {
|
||||
"startLine": 11,
|
||||
"startChar": 0,
|
||||
"endLine": 11,
|
||||
"endChar": 7
|
||||
},
|
||||
"revId": "b492c3c3ca3b81417d447a37eb13740cab6d58a7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "7ba7decf_1d5f5f0c",
|
||||
"filename": "osci.yaml",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 5,
|
||||
"author": {
|
||||
"id": 20870
|
||||
},
|
||||
"writtenOn": "2022-07-20T12:10:42Z",
|
||||
"side": 1,
|
||||
"message": "remove xena as the charm doesn\u0027t need to support xena. We do need to keep yoga functional jobs as the charm needs to be able to upgrade from yoga.",
|
||||
"range": {
|
||||
"startLine": 5,
|
||||
"startChar": 0,
|
||||
"endLine": 5,
|
||||
"endChar": 34
|
||||
},
|
||||
"revId": "b492c3c3ca3b81417d447a37eb13740cab6d58a7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "58659f0d_1e3bacf9",
|
||||
"filename": "tests/tests.yaml",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 10,
|
||||
"author": {
|
||||
"id": 20870
|
||||
},
|
||||
"writtenOn": "2022-07-20T12:10:42Z",
|
||||
"side": 1,
|
||||
"message": "remove focal-yoga as it is no longer needed; this also means that the focal-yoga bundle can be removed.",
|
||||
"range": {
|
||||
"startLine": 10,
|
||||
"startChar": 0,
|
||||
"endLine": 10,
|
||||
"endChar": 14
|
||||
},
|
||||
"revId": "b492c3c3ca3b81417d447a37eb13740cab6d58a7",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue