From cf162a96fcc89458cab7991790a956e0edc28e1f Mon Sep 17 00:00:00 2001 From: Ryan Beisner Date: Thu, 22 Sep 2016 17:57:58 +0000 Subject: [PATCH] Update amulet test definitions for Newton - Remove Precise-Icehouse Amulet test definitions if they exist. - Add Xenial-Newton Amulet test definitions. - Add Yakkety-Newton Amulet test definitions. - Use the percona-cluster charm in tests instead of the mysql charm. Change-Id: I284cd94772f2e5d38342330910e835b4feef58af --- .../contrib/openstack/amulet/deployment.py | 2 +- .../contrib/openstack/amulet/utils.py | 11 +++---- hooks/charmhelpers/contrib/openstack/utils.py | 5 ++-- tests/basic_deployment.py | 29 ++++++++++--------- .../contrib/openstack/amulet/deployment.py | 2 +- .../contrib/openstack/amulet/utils.py | 11 +++---- tests/gate-basic-precise-icehouse | 25 ---------------- ...xenial-newton => gate-basic-xenial-newton} | 0 ...kkety-newton => gate-basic-yakkety-newton} | 0 tests/tests.yaml | 2 +- 10 files changed, 30 insertions(+), 57 deletions(-) delete mode 100755 tests/gate-basic-precise-icehouse rename tests/{dev-basic-xenial-newton => gate-basic-xenial-newton} (100%) rename tests/{dev-basic-yakkety-newton => gate-basic-yakkety-newton} (100%) mode change 100755 => 100644 diff --git a/hooks/charmhelpers/contrib/openstack/amulet/deployment.py b/hooks/charmhelpers/contrib/openstack/amulet/deployment.py index 6fe8cf8..9e0b07f 100644 --- a/hooks/charmhelpers/contrib/openstack/amulet/deployment.py +++ b/hooks/charmhelpers/contrib/openstack/amulet/deployment.py @@ -156,7 +156,7 @@ class OpenStackAmuletDeployment(AmuletDeployment): use_source = list(set( use_source + ['mysql', 'mongodb', 'rabbitmq-server', 'ceph', 'ceph-osd', 'ceph-radosgw', 'ceph-mon', - 'ceph-proxy'])) + 'ceph-proxy', 'percona-cluster', 'lxd'])) # Charms which can not use openstack-origin, ie. many subordinates no_origin = list(set( diff --git a/hooks/charmhelpers/contrib/openstack/amulet/utils.py b/hooks/charmhelpers/contrib/openstack/amulet/utils.py index 24b353e..e4546c8 100644 --- a/hooks/charmhelpers/contrib/openstack/amulet/utils.py +++ b/hooks/charmhelpers/contrib/openstack/amulet/utils.py @@ -306,10 +306,8 @@ class OpenStackAmuletUtils(AmuletUtils): password, tenant): """Authenticates admin user with cinder.""" # NOTE(beisner): cinder python client doesn't accept tokens. - service_ip = \ - keystone_sentry.relation('shared-db', - 'mysql:shared-db')['private-address'] - ept = "http://{}:5000/v2.0".format(service_ip.strip().decode('utf-8')) + keystone_ip = keystone_sentry.info['public-address'] + ept = "http://{}:5000/v2.0".format(keystone_ip.strip().decode('utf-8')) return cinder_client.Client(username, password, tenant, ept) def authenticate_keystone_admin(self, keystone_sentry, user, password, @@ -317,10 +315,9 @@ class OpenStackAmuletUtils(AmuletUtils): keystone_ip=None): """Authenticates admin user with the keystone admin endpoint.""" self.log.debug('Authenticating keystone admin...') - unit = keystone_sentry if not keystone_ip: - keystone_ip = unit.relation('shared-db', - 'mysql:shared-db')['private-address'] + keystone_ip = keystone_sentry.info['public-address'] + base_ep = "http://{}:35357".format(keystone_ip.strip().decode('utf-8')) if not api_version or api_version == 2: ep = base_ep + "/v2.0" diff --git a/hooks/charmhelpers/contrib/openstack/utils.py b/hooks/charmhelpers/contrib/openstack/utils.py index 9abd4c3..8c89c3a 100644 --- a/hooks/charmhelpers/contrib/openstack/utils.py +++ b/hooks/charmhelpers/contrib/openstack/utils.py @@ -229,6 +229,7 @@ GIT_DEFAULT_REPOS = { GIT_DEFAULT_BRANCHES = { 'liberty': 'stable/liberty', 'mitaka': 'stable/mitaka', + 'newton': 'stable/newton', 'master': 'master', } @@ -735,12 +736,12 @@ def git_os_codename_install_source(projects_yaml): if projects in GIT_DEFAULT_BRANCHES.keys(): if projects == 'master': - return 'newton' + return 'ocata' return projects if 'release' in projects: if projects['release'] == 'master': - return 'newton' + return 'ocata' return projects['release'] return None diff --git a/tests/basic_deployment.py b/tests/basic_deployment.py index 43d63f9..dab1f75 100644 --- a/tests/basic_deployment.py +++ b/tests/basic_deployment.py @@ -50,9 +50,10 @@ class CinderBackupBasicDeployment(OpenStackAmuletDeployment): # XXX: cinder-backup workload status ignored until it grows support # https://bugs.launchpad.net/bugs/1604580 - exclude_services = ['mysql', 'cinder-backup'] + exclude_services = ['cinder-backup'] self._auto_wait_for_status(exclude_services=exclude_services) + self.d.sentry.wait() self._initialize_tests() def _add_services(self): @@ -63,12 +64,12 @@ class CinderBackupBasicDeployment(OpenStackAmuletDeployment): # Note: cinder-backup becomes a cinder subordinate unit. this_service = {'name': 'cinder-backup'} other_services = [ - {'name': 'mysql'}, + {'name': 'percona-cluster', 'constraints': {'mem': '3072M'}}, {'name': 'keystone'}, {'name': 'rabbitmq-server'}, {'name': 'ceph', 'units': 3}, {'name': 'cinder'}, - {'name': 'cinder-ceph'} + {'name': 'cinder-ceph'}, ] super(CinderBackupBasicDeployment, self)._add_services(this_service, other_services) @@ -81,8 +82,8 @@ class CinderBackupBasicDeployment(OpenStackAmuletDeployment): 'cinder-ceph:ceph': 'ceph:client', 'cinder:storage-backend': 'cinder-ceph:storage-backend', 'cinder:backup-backend': 'cinder-backup:backup-backend', - 'keystone:shared-db': 'mysql:shared-db', - 'cinder:shared-db': 'mysql:shared-db', + 'keystone:shared-db': 'percona-cluster:shared-db', + 'cinder:shared-db': 'percona-cluster:shared-db', 'cinder:identity-service': 'keystone:identity-service', 'cinder:amqp': 'rabbitmq-server:amqp', } @@ -94,8 +95,11 @@ class CinderBackupBasicDeployment(OpenStackAmuletDeployment): 'admin-password': 'openstack', 'admin-token': 'ubuntutesting' } - mysql_config = { - 'dataset-size': '50%' + pxc_config = { + 'dataset-size': '25%', + 'max-connections': 1000, + 'root-password': 'ChangeMe123', + 'sst-password': 'ChangeMe123', } cinder_config = { 'block-device': 'None', @@ -115,18 +119,18 @@ class CinderBackupBasicDeployment(OpenStackAmuletDeployment): } configs = { 'keystone': keystone_config, - 'mysql': mysql_config, + 'percona-cluster': pxc_config, 'cinder': cinder_config, 'ceph': ceph_config, 'cinder-ceph': cinder_ceph_config, - 'cinder-backup': cinder_ceph_config + 'cinder-backup': cinder_ceph_config, } super(CinderBackupBasicDeployment, self)._configure_services(configs) def _initialize_tests(self): """Perform final initialization before tests get run.""" # Access the sentries for inspecting service units - self.mysql_sentry = self.d.sentry['mysql'][0] + self.pxc_sentry = self.d.sentry['percona-cluster'][0] self.keystone_sentry = self.d.sentry['keystone'][0] self.rabbitmq_sentry = self.d.sentry['rabbitmq-server'][0] self.cinder_sentry = self.d.sentry['cinder'][0] @@ -201,7 +205,6 @@ class CinderBackupBasicDeployment(OpenStackAmuletDeployment): def test_102_services(self): """Verify the expected services are running on the service units.""" services = { - self.mysql_sentry: ['mysql'], self.rabbitmq_sentry: ['rabbitmq-server'], self.keystone_sentry: ['keystone'], self.cinder_sentry: ['cinder-api', @@ -423,7 +426,7 @@ class CinderBackupBasicDeployment(OpenStackAmuletDeployment): def test_204_mysql_cinder_db_relation(self): """Verify the mysql:glance shared-db relation data""" u.log.debug('Checking mysql:cinder db relation data...') - unit = self.mysql_sentry + unit = self.pxc_sentry relation = ['shared-db', 'cinder:shared-db'] expected = { 'private-address': u.valid_ip, @@ -438,7 +441,7 @@ class CinderBackupBasicDeployment(OpenStackAmuletDeployment): """Verify the cinder:mysql shared-db relation data""" u.log.debug('Checking cinder:mysql db relation data...') unit = self.cinder_sentry - relation = ['shared-db', 'mysql:shared-db'] + relation = ['shared-db', 'percona-cluster:shared-db'] expected = { 'private-address': u.valid_ip, 'hostname': u.valid_ip, diff --git a/tests/charmhelpers/contrib/openstack/amulet/deployment.py b/tests/charmhelpers/contrib/openstack/amulet/deployment.py index 6fe8cf8..9e0b07f 100644 --- a/tests/charmhelpers/contrib/openstack/amulet/deployment.py +++ b/tests/charmhelpers/contrib/openstack/amulet/deployment.py @@ -156,7 +156,7 @@ class OpenStackAmuletDeployment(AmuletDeployment): use_source = list(set( use_source + ['mysql', 'mongodb', 'rabbitmq-server', 'ceph', 'ceph-osd', 'ceph-radosgw', 'ceph-mon', - 'ceph-proxy'])) + 'ceph-proxy', 'percona-cluster', 'lxd'])) # Charms which can not use openstack-origin, ie. many subordinates no_origin = list(set( diff --git a/tests/charmhelpers/contrib/openstack/amulet/utils.py b/tests/charmhelpers/contrib/openstack/amulet/utils.py index 24b353e..e4546c8 100644 --- a/tests/charmhelpers/contrib/openstack/amulet/utils.py +++ b/tests/charmhelpers/contrib/openstack/amulet/utils.py @@ -306,10 +306,8 @@ class OpenStackAmuletUtils(AmuletUtils): password, tenant): """Authenticates admin user with cinder.""" # NOTE(beisner): cinder python client doesn't accept tokens. - service_ip = \ - keystone_sentry.relation('shared-db', - 'mysql:shared-db')['private-address'] - ept = "http://{}:5000/v2.0".format(service_ip.strip().decode('utf-8')) + keystone_ip = keystone_sentry.info['public-address'] + ept = "http://{}:5000/v2.0".format(keystone_ip.strip().decode('utf-8')) return cinder_client.Client(username, password, tenant, ept) def authenticate_keystone_admin(self, keystone_sentry, user, password, @@ -317,10 +315,9 @@ class OpenStackAmuletUtils(AmuletUtils): keystone_ip=None): """Authenticates admin user with the keystone admin endpoint.""" self.log.debug('Authenticating keystone admin...') - unit = keystone_sentry if not keystone_ip: - keystone_ip = unit.relation('shared-db', - 'mysql:shared-db')['private-address'] + keystone_ip = keystone_sentry.info['public-address'] + base_ep = "http://{}:35357".format(keystone_ip.strip().decode('utf-8')) if not api_version or api_version == 2: ep = base_ep + "/v2.0" diff --git a/tests/gate-basic-precise-icehouse b/tests/gate-basic-precise-icehouse deleted file mode 100755 index 06843b7..0000000 --- a/tests/gate-basic-precise-icehouse +++ /dev/null @@ -1,25 +0,0 @@ -#!/usr/bin/env python -# -# Copyright 2016 Canonical Ltd -# -# Licensed under the Apache License, Version 2.0 (the "License"); -# you may not use this file except in compliance with the License. -# You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -"""Amulet tests on a basic cinder-backup deployment on precise-icehouse.""" - -from basic_deployment import CinderBackupBasicDeployment - -if __name__ == '__main__': - deployment = CinderBackupBasicDeployment(series='precise', - openstack='cloud:precise-icehouse', - source='cloud:precise-updates/icehouse') - deployment.run_tests() diff --git a/tests/dev-basic-xenial-newton b/tests/gate-basic-xenial-newton similarity index 100% rename from tests/dev-basic-xenial-newton rename to tests/gate-basic-xenial-newton diff --git a/tests/dev-basic-yakkety-newton b/tests/gate-basic-yakkety-newton old mode 100755 new mode 100644 similarity index 100% rename from tests/dev-basic-yakkety-newton rename to tests/gate-basic-yakkety-newton diff --git a/tests/tests.yaml b/tests/tests.yaml index e3185c6..4cf93d0 100644 --- a/tests/tests.yaml +++ b/tests/tests.yaml @@ -1,6 +1,6 @@ # Bootstrap the model if necessary. bootstrap: True -# Re-use bootstrap node instead of destroying/re-bootstrapping. +# Re-use bootstrap node. reset: True # Use tox/requirements to drive the venv instead of bundletester's venv feature. virtualenv: False