openstack/charm-cinder
Code Issues Proposed changes

Use an actual boolean for remove-missing. Thanks to ryan.harper@canonical.com for contributions to the remove-missing support.

Browse Source
This commit is contained in:
Corey Bryant 2014-10-09 19:51:49 +00:00
parent 5f332c9f57
commit 441edad8ec
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
config.yaml
View File

@ -58,10 +58,10 @@ options:
If true, charm will attempt to overwrite block devices containing
previous filesystems or LVM, assuming it is not in use.
remove-missing:
default: "false"
type: string
default: False
type: boolean
description: |
If true, charm will attempt to remove missing physical volumes from
If True, charm will attempt to remove missing physical volumes from
volume group, if logical volumes are not allocated on them.
database-user:
default: cinder

2
hooks/cinder_hooks.py
View File

@ -106,7 +106,7 @@ def config_changed():
configure_lvm_storage(block_devices,
conf['volume-group'],
conf['overwrite'] in ['true', 'True', True],
conf['remove-missing'] in ['true', 'True', True])
conf['remove-missing'])
if openstack_upgrade_available('cinder-common'):
do_openstack_upgrade(configs=CONFIGS)