openstack/charm-cinder
Code Issues Proposed changes

Update pre-install hooks to fail on error

Browse Source 
The pre-install operations may fail, yet that failure is not
elevated to the user. This masks the failure and makes early
package install issues difficult to troubleshoot.

If the basic pre-install script fails, the charm should not
proceed to later hooks as the requirements may not be met.

Hashbangs for bash should specify -e (errexit) on all of the
pre-install bash scripts.

Change-Id: I3e421d586df341113bbcd1888f280a2ea24c52b9
Closes-bug: #1815243
Partial-bug: #1815231
This commit is contained in:
Ryan Beisner 2019-02-08 15:47:41 -06:00
parent 834cde35ec
commit 9eb22b8949
No known key found for this signature in database
GPG Key ID: 952BACDC1C1A05FB
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hooks/install
View File

@ -1,4 +1,4 @@
#!/bin/bash
#!/bin/bash -e
# Wrapper to deal with newer Ubuntu versions that don't have py2 installed
# by default.