openstack/charm-cinder
Code Issues Proposed changes

Fixup based on feedback

Browse Source
This commit is contained in:
James Page 2015-04-21 16:20:20 +01:00
parent b147c1a84b
commit d1a5515de9
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hooks/cinder_hooks.py
View File

@ -200,7 +200,7 @@ def db_changed():
migrate_database() migrate_database()
else: else:
juju_log('allowed_units either not presented, or local unit ' juju_log('allowed_units either not presented, or local unit '
'not in acl list: %s' % allowed_units) 'not in acl list: %s' % repr(allowed_units))
@hooks.hook('pgsql-db-relation-changed') @hooks.hook('pgsql-db-relation-changed')

2
unit_tests/test_cinder_hooks.py
View File

@ -245,7 +245,7 @@ class TestChangedHooks(CharmTestCase):
self.assertFalse(self.migrate_database.called) self.assertFalse(self.migrate_database.called)
def test_db_changed_relation_db_missing_acls(self): def test_db_changed_relation_db_missing_acls(self):
'It does not migration when acl list is not present' 'No database migration is attempted when ACL list is not present'
self.relation_get.return_value = None self.relation_get.return_value = None
self.local_unit.return_value = 'cinder/0' self.local_unit.return_value = 'cinder/0'
self.CONFIGS.complete_contexts.return_value = ['shared-db'] self.CONFIGS.complete_contexts.return_value = ['shared-db']