97d5773977
test_clean_storage_unmount incorrectly used 'called_with' instead of 'assert_called_with' which just made a mock function call and didn't check or assert that the function was actually called. As a result this function didn't actually test anything, the expected parameters were not correct so they have been updated. An error to catch this accidental mistake was added in the recently released mock 5.0.1 (https://github.com/python/cpython/issues/100690) AttributeError: 'called_with' is not a valid assertion. Use a spec for the mock if 'called_with' is meant to be an attribute. The mock library ships in python as unittest.mock but also publishes the latest code as the 'mock' python package so that older python versions can get the latest code. The stable branches currently install mock but the master branch does not, so this error does not actually appear on master but only the <=yoga stable branches currently. The test is however wrong either way. Change-Id: I3076778e8fc62c086651d29abb2c5a3d9921be97 |
||
---|---|---|
.. | ||
__init__.py | ||
test_actions_cinder_manage.py | ||
test_actions_openstack_upgrade.py | ||
test_actions.py | ||
test_cinder_contexts.py | ||
test_cinder_hooks.py | ||
test_cinder_utils.py | ||
test_cluster_hooks.py | ||
test_utils.py |