Misc tidy of lint

Remove upper bound on flake8 and tidy misc lint on codebase.

Note that one of the warning messages signalled that a parameter
was not used in a format call. This may or may not be correct
but this commit sticks with the existing behaviour.

Change-Id: Ifa178694a97997f992afa88f4a8f3bead09ced3b

src/lib/charm/openstack/designate_bind.py

@@ -343,7 +343,8 @@ class DesignateBindCharm(openstack_charm.OpenStackCharm):
 
         :returns: None
         """
-        sync_dir = '{}/zone-syncs'.format(WWW_DIR, sync_time)
+        # NOTE(jamespage): sync_time is not used in the path?
+        sync_dir = '{}/zone-syncs'.format(WWW_DIR)
         try:
             os.mkdir(sync_dir, 0o755)
         except FileExistsError:

test-requirements.txt

@@ -3,7 +3,7 @@
 # requirements management in charms via bot-control.  Thank you.
 #
 # Lint and unit test requirements
-flake8>=2.2.4,<=2.4.1
+flake8>=2.2.4
 stestr>=2.2.0
 requests>=2.18.4
 charms.reactive

unit_tests/__init__.py

@@ -32,6 +32,7 @@ def _fake_retry(num_retries, base_delay=0, exc_type=Exception):
         return _retry_on_exception_inner_2
     return _retry_on_exception_inner_1
 
+
 mock.patch(
     'charmhelpers.core.decorators.retry_on_exception',
     _fake_retry).start()

unit_tests/test_designate_bind_handlers.py

@@ -143,8 +143,8 @@ class TestDesignateHandlers(unittest.TestCase):
                 print(f)
                 self.assertTrue(f in p.keys())
                 # check that the lists are equal
-                l = [a['args'] for a in args]
-                self.assertEqual(l, p[f])
+                newlist = [a['args'] for a in args]
+                self.assertEqual(newlist, p[f])
 
     def test_install_packages(self):
         self.patch(handlers.designate_bind, 'install')