openstack/charm-designate
Code Issues Proposed changes

Change assertTrue(isinstance()) by optimal assert

Browse Source 
Some of tests use different method of
assertTrue(isinstance(A, B)) or assertEqual(type(A), B).
The correct way is to use assertIsInstance(A, B) provided
by testtools

Change-Id: If16d3c28a7c0d40b291f5f59d7413d401acd0502
This commit is contained in:
gecong1973 2016-10-08 12:03:25 +08:00
parent 06d7b798f8
commit 0dc1ff03f7
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
unit_tests/test_lib_charm_openstack_designate.py
View File

@ -304,8 +304,8 @@ class TestDesignateAdapters(Helper):
isinstance( isinstance(
b.other, b.other,
designate.openstack_adapters.OpenStackRelationAdapter)) designate.openstack_adapters.OpenStackRelationAdapter))
self.assertTrue(isinstance(b.options, self.assertIsInstance(b.options,
designate.DesignateConfigurationAdapter)) designate.DesignateConfigurationAdapter)
class TestDesignateCharm(Helper): class TestDesignateCharm(Helper):