From 0dc1ff03f74fa5dde82afd896b5233447431dd35 Mon Sep 17 00:00:00 2001 From: gecong1973 Date: Sat, 8 Oct 2016 12:03:25 +0800 Subject: [PATCH] Change assertTrue(isinstance()) by optimal assert Some of tests use different method of assertTrue(isinstance(A, B)) or assertEqual(type(A), B). The correct way is to use assertIsInstance(A, B) provided by testtools Change-Id: If16d3c28a7c0d40b291f5f59d7413d401acd0502 --- unit_tests/test_lib_charm_openstack_designate.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/unit_tests/test_lib_charm_openstack_designate.py b/unit_tests/test_lib_charm_openstack_designate.py index 00b782d..4d694d8 100644 --- a/unit_tests/test_lib_charm_openstack_designate.py +++ b/unit_tests/test_lib_charm_openstack_designate.py @@ -304,8 +304,8 @@ class TestDesignateAdapters(Helper): isinstance( b.other, designate.openstack_adapters.OpenStackRelationAdapter)) - self.assertTrue(isinstance(b.options, - designate.DesignateConfigurationAdapter)) + self.assertIsInstance(b.options, + designate.DesignateConfigurationAdapter) class TestDesignateCharm(Helper):